From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#25561: 25.1; "Making isearch-search-fun-function local to *Minibuf-1* while let-bound!" warning with Evil Date: Fri, 10 Feb 2017 12:16:32 +0200 Message-ID: <8360ki4agv.fsf@gnu.org> References: <8760kyzoma.fsf@mail.linkov.net> <20170208125523.GA703@odonien.localdomain> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1486721840 9436 195.159.176.226 (10 Feb 2017 10:17:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 10 Feb 2017 10:17:20 +0000 (UTC) Cc: 25561@debbugs.gnu.org, v.schneidermann@gmail.com, juri@linkov.net To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Feb 10 11:17:10 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cc8GJ-0001cj-Dn for geb-bug-gnu-emacs@m.gmane.org; Fri, 10 Feb 2017 11:17:07 +0100 Original-Received: from localhost ([::1]:42906 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cc8GO-00072L-Mp for geb-bug-gnu-emacs@m.gmane.org; Fri, 10 Feb 2017 05:17:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39273) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cc8GI-00070r-Mr for bug-gnu-emacs@gnu.org; Fri, 10 Feb 2017 05:17:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cc8GE-0004Y4-La for bug-gnu-emacs@gnu.org; Fri, 10 Feb 2017 05:17:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35654) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cc8GE-0004Xn-IK for bug-gnu-emacs@gnu.org; Fri, 10 Feb 2017 05:17:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cc8GE-0003sf-CZ for bug-gnu-emacs@gnu.org; Fri, 10 Feb 2017 05:17:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Feb 2017 10:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25561 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25561-submit@debbugs.gnu.org id=B25561.148672180414888 (code B ref 25561); Fri, 10 Feb 2017 10:17:02 +0000 Original-Received: (at 25561) by debbugs.gnu.org; 10 Feb 2017 10:16:44 +0000 Original-Received: from localhost ([127.0.0.1]:33853 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cc8Fv-0003s4-Tb for submit@debbugs.gnu.org; Fri, 10 Feb 2017 05:16:44 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:48186) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cc8Ft-0003rr-V0 for 25561@debbugs.gnu.org; Fri, 10 Feb 2017 05:16:42 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cc8Fn-0004ST-ST for 25561@debbugs.gnu.org; Fri, 10 Feb 2017 05:16:36 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:32868) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cc8Fe-0004Rg-0S; Fri, 10 Feb 2017 05:16:26 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4638 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cc8Fd-0002Y9-5v; Fri, 10 Feb 2017 05:16:25 -0500 In-reply-to: (message from Stefan Monnier on Wed, 08 Feb 2017 17:21:11 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:129197 Archived-At: > From: Stefan Monnier > Date: Wed, 08 Feb 2017 17:21:11 -0500 > Cc: 25561@debbugs.gnu.org, Juri Linkov > > >> > a user of the Evil package reported [1] that using a search command > >> > results in a "Making isearch-search-fun-function local to *Minibuf-1* > >> > while let-bound!" warning. This appears to be an interaction between > >> > isearch and Evil, more specifically, Evil let-binds > >> > `isearch-search-fun-function' to something of its own, invokes isearch > >> > and something in isearch ends up running > >> > `minibuffer-history-isearch-setup' which `make-local-variable' to have > >> > `isearch-search-fun-function' have a separate value, resulting in the > >> > aforementioned warning. > >> > > >> > What's the recommended way to avoid or silence it? Stefan suggested > >> > elsewhere [2] that this might indicate a bug, hence why I'm bringing > >> > this up here. > > I plead guilty of adding this warning. But FWIW, I think it was > misguided: the interaction between make-local-variable and let-binding > can be pretty tricky, which is why I added the warning (thinking that > such things should better be avoided), but in my subsequent experience, > I haven't found a single case where the problem is real. Worse: it's > often difficult/ugly to change the code to avoid the "tricky" > interaction, because the code that does the let-binding doesn't know > about the other and vice-versa. > > So, while the trickiness rmains, I think it's best to just hope for the > best, silently, rather than signal a warning that nobody (not even me) > knows how to address satisfactorily. So you are saying we should remove that warning entirely? What about the other warning, "Making FOO buffer-local while let-bound!"?