From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: 25561@debbugs.gnu.org, v.schneidermann@gmail.com, juri@linkov.net
Subject: bug#25561: 25.1; "Making isearch-search-fun-function local to *Minibuf-1* while let-bound!" warning with Evil
Date: Fri, 10 Feb 2017 12:16:32 +0200 [thread overview]
Message-ID: <8360ki4agv.fsf@gnu.org> (raw)
In-Reply-To: <jwvk29049al.fsf-monnier+emacsbugs@gnu.org> (message from Stefan Monnier on Wed, 08 Feb 2017 17:21:11 -0500)
> From: Stefan Monnier <monnier@IRO.UMontreal.CA>
> Date: Wed, 08 Feb 2017 17:21:11 -0500
> Cc: 25561@debbugs.gnu.org, Juri Linkov <juri@linkov.net>
>
> >> > a user of the Evil package reported [1] that using a search command
> >> > results in a "Making isearch-search-fun-function local to *Minibuf-1*
> >> > while let-bound!" warning. This appears to be an interaction between
> >> > isearch and Evil, more specifically, Evil let-binds
> >> > `isearch-search-fun-function' to something of its own, invokes isearch
> >> > and something in isearch ends up running
> >> > `minibuffer-history-isearch-setup' which `make-local-variable' to have
> >> > `isearch-search-fun-function' have a separate value, resulting in the
> >> > aforementioned warning.
> >> >
> >> > What's the recommended way to avoid or silence it? Stefan suggested
> >> > elsewhere [2] that this might indicate a bug, hence why I'm bringing
> >> > this up here.
>
> I plead guilty of adding this warning. But FWIW, I think it was
> misguided: the interaction between make-local-variable and let-binding
> can be pretty tricky, which is why I added the warning (thinking that
> such things should better be avoided), but in my subsequent experience,
> I haven't found a single case where the problem is real. Worse: it's
> often difficult/ugly to change the code to avoid the "tricky"
> interaction, because the code that does the let-binding doesn't know
> about the other and vice-versa.
>
> So, while the trickiness rmains, I think it's best to just hope for the
> best, silently, rather than signal a warning that nobody (not even me)
> knows how to address satisfactorily.
So you are saying we should remove that warning entirely?
What about the other warning, "Making FOO buffer-local while let-bound!"?
next prev parent reply other threads:[~2017-02-10 10:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-28 11:03 bug#25561: 25.1; "Making isearch-search-fun-function local to *Minibuf-1* while let-bound!" warning with Evil Vasilij Schneidermann
[not found] ` <8760kyzoma.fsf@mail.linkov.net>
2017-01-29 12:25 ` Vasilij Schneidermann
2017-02-08 12:55 ` Vasilij Schneidermann
2017-02-08 22:21 ` Stefan Monnier
2017-02-10 10:16 ` Eli Zaretskii [this message]
2017-02-10 12:45 ` Stefan Monnier
2017-02-18 9:29 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8360ki4agv.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=25561@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=monnier@IRO.UMontreal.CA \
--cc=v.schneidermann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.