From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 bc55a57: * lisp/menu-bar.el (kill-this-buffer): Doc fix. (Bug#26466) Date: Sun, 16 Apr 2017 23:07:49 +0300 Message-ID: <8360i4f756.fsf@gnu.org> References: <20170412194437.19648.75020@vcs0.savannah.gnu.org> <20170412194438.934FD22EE8@vcs0.savannah.gnu.org> <87shldl1v8.fsf@localhost> <83h91sizcn.fsf@gnu.org> <87vaq79903.fsf@localhost> <83r30vh2k3.fsf@gnu.org> <83bmrwfg43.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1492373276 20504 195.159.176.226 (16 Apr 2017 20:07:56 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 16 Apr 2017 20:07:56 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 16 22:07:52 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1czqSe-0005CL-2T for ged-emacs-devel@m.gmane.org; Sun, 16 Apr 2017 22:07:52 +0200 Original-Received: from localhost ([::1]:33457 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1czqSg-0005Vr-LW for ged-emacs-devel@m.gmane.org; Sun, 16 Apr 2017 16:07:54 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37451) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1czqSA-0005Vl-Ng for emacs-devel@gnu.org; Sun, 16 Apr 2017 16:07:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1czqS7-0002wH-Kg for emacs-devel@gnu.org; Sun, 16 Apr 2017 16:07:22 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34341) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1czqS7-0002wD-Gx; Sun, 16 Apr 2017 16:07:19 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4392 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1czqS6-0002He-Ro; Sun, 16 Apr 2017 16:07:19 -0400 In-reply-to: (message from Stefan Monnier on Sun, 16 Apr 2017 15:22:53 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214024 Archived-At: > From: Stefan Monnier > Date: Sun, 16 Apr 2017 15:22:53 -0400 > > > Thanks, but I'm not interested. This code existed for years, and it > > never bothered you or anyone else, so we won't change it now. > > It's a (cleaner) alternative to the fix below: > > commit 96ef9ccd1b0a28c774ad5b9ffbfb811de540eb30 > Author: Martin Rudalics > Date: Wed Oct 3 10:50:49 2012 +0200 > > Have kill-this-buffer don't do anything when frame is not alive or visible (Bug#8184). > > * menu-bar.el (kill-this-buffer): Don't do anything when > `menu-frame' is not alive or visible (Bug#8184). > > so, yes, it's been around for a few years but it was pretty ugly. We (and you in particular) have lived with that "ugliness" for almost 5 years, so I guess it's not that ugly after all.