From: Eli Zaretskii <eliz@gnu.org>
To: "Charles A. Roelli" <charles@aurox.ch>
Cc: 27024-done@debbugs.gnu.org
Subject: bug#27024: 25.2: gud.el: wrong menu :visible for pdb
Date: Sat, 27 May 2017 15:17:00 +0300 [thread overview]
Message-ID: <8360gmijer.fsf@gnu.org> (raw)
In-Reply-To: <ofvatd$mda$1@blaine.gmane.org> (charles@aurox.ch)
> From: "Charles A. Roelli" <charles@aurox.ch>
> Date: Mon, 22 May 2017 20:33:26 +0200
>
> The "stop" entry in `gud-menu-map' (line 158):
>
> ([stop] menu-item "Stop" gud-stop-subjob
> :visible (or (not (memq gud-minor-mode '(gdbmi pdb)))
> (gdb-show-stop-p)))
>
> has a :visible entry that calls `gdb-show-stop-p' if `gud-minor-mode' is
> either
> `gdbmi' or `pdb'. This function is only related to gdb and isn't loaded
> by running
> just pdb, so it can cause an error during redisplay (but interestingly,
> it doesn't seem to happen all the time while running pdb -- or maybe the
> error is
> caught somehow).
>
> Does anyone understand why this check for pdb is here? It seems to be a
> mistake,
> but it has been there for more than 7 years...
>
> Otherwise, could someone please remove the check for pdb? Thanks.
Thanks, I've modified the test to not call gdb-show-stop-p in pdb
mode.
prev parent reply other threads:[~2017-05-27 12:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 18:33 bug#27024: 25.2: gud.el: wrong menu :visible for pdb Charles A. Roelli
2017-05-27 12:17 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8360gmijer.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=27024-done@debbugs.gnu.org \
--cc=charles@aurox.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.