From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#27817: 26.0.50; Dired: Support eshell/ls from the beginning if user want to Date: Tue, 25 Jul 2017 17:33:48 +0300 Message-ID: <8360eg7fhv.fsf@gnu.org> References: <87shhlypn6.fsf@calancha-pc> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1500993257 31076 195.159.176.226 (25 Jul 2017 14:34:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 25 Jul 2017 14:34:17 +0000 (UTC) Cc: 27817@debbugs.gnu.org To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 25 16:34:13 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1da0uW-0007cy-8d for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Jul 2017 16:34:08 +0200 Original-Received: from localhost ([::1]:32904 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1da0ub-0007s3-U0 for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Jul 2017 10:34:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34090) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1da0uT-0007qY-RO for bug-gnu-emacs@gnu.org; Tue, 25 Jul 2017 10:34:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1da0uQ-0005Tl-Nx for bug-gnu-emacs@gnu.org; Tue, 25 Jul 2017 10:34:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53343) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1da0uQ-0005TY-L1 for bug-gnu-emacs@gnu.org; Tue, 25 Jul 2017 10:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1da0uQ-00069b-EX for bug-gnu-emacs@gnu.org; Tue, 25 Jul 2017 10:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Jul 2017 14:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27817 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 27817-submit@debbugs.gnu.org id=B27817.150099323723645 (code B ref 27817); Tue, 25 Jul 2017 14:34:02 +0000 Original-Received: (at 27817) by debbugs.gnu.org; 25 Jul 2017 14:33:57 +0000 Original-Received: from localhost ([127.0.0.1]:56020 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1da0uL-00069I-Ap for submit@debbugs.gnu.org; Tue, 25 Jul 2017 10:33:57 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:42986) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1da0uK-000696-Bq for 27817@debbugs.gnu.org; Tue, 25 Jul 2017 10:33:56 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1da0uC-0005F0-3s for 27817@debbugs.gnu.org; Tue, 25 Jul 2017 10:33:51 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33018) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1da0uC-0005Ep-1b; Tue, 25 Jul 2017 10:33:48 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4378 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1da0uB-0003zs-NT; Tue, 25 Jul 2017 10:33:47 -0400 In-reply-to: <87shhlypn6.fsf@calancha-pc> (message from Tino Calancha on Tue, 25 Jul 2017 15:52:29 +0900) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:134968 Archived-At: > From: Tino Calancha > Date: Tue, 25 Jul 2017 15:52:29 +0900 > > commit 6322f2932e9a083e01bb86aa219fc8256443c33f > Author: Tino Calancha > Date: Tue Jul 25 15:46:54 2017 +0900 > > Dired: Support eshell/ls from the beginning if user want to > > * lisp/dired.el (dired-insert-directory): Check for em-ls as well. > * test/lisp/dired-tests.el (dired-test-bug27817): Add test. Looks okay, but (a) please cite the bug number in the commit log message, and (b) shouldn't this: > + (not (and (featurep 'eshell) (bound-and-true-p eshell-ls-use-in-dired))) ^^^^^^^^^^^^^^^^^^^^^^ quote eshell-ls-use-in-dired? Thanks.