From: Eli Zaretskii <eliz@gnu.org>
To: Tino Calancha <tino.calancha@gmail.com>
Cc: 27817@debbugs.gnu.org
Subject: bug#27817: 26.0.50; Dired: Support eshell/ls from the beginning if user want to
Date: Tue, 25 Jul 2017 17:33:48 +0300 [thread overview]
Message-ID: <8360eg7fhv.fsf@gnu.org> (raw)
In-Reply-To: <87shhlypn6.fsf@calancha-pc> (message from Tino Calancha on Tue, 25 Jul 2017 15:52:29 +0900)
> From: Tino Calancha <tino.calancha@gmail.com>
> Date: Tue, 25 Jul 2017 15:52:29 +0900
>
> commit 6322f2932e9a083e01bb86aa219fc8256443c33f
> Author: Tino Calancha <tino.calancha@gmail.com>
> Date: Tue Jul 25 15:46:54 2017 +0900
>
> Dired: Support eshell/ls from the beginning if user want to
>
> * lisp/dired.el (dired-insert-directory): Check for em-ls as well.
> * test/lisp/dired-tests.el (dired-test-bug27817): Add test.
Looks okay, but (a) please cite the bug number in the commit log
message, and (b) shouldn't this:
> + (not (and (featurep 'eshell) (bound-and-true-p eshell-ls-use-in-dired)))
^^^^^^^^^^^^^^^^^^^^^^
quote eshell-ls-use-in-dired?
Thanks.
next prev parent reply other threads:[~2017-07-25 14:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 6:52 bug#27817: 26.0.50; Dired: Support eshell/ls from the beginning if user want to Tino Calancha
2017-07-25 7:00 ` Tino Calancha
2017-07-25 14:33 ` Eli Zaretskii [this message]
2017-07-25 14:38 ` Tino Calancha
2017-07-25 14:48 ` Noam Postavsky
2017-07-25 15:02 ` Eli Zaretskii
2017-07-25 15:09 ` Tino Calancha
2017-07-25 15:27 ` Noam Postavsky
2017-07-25 15:34 ` Tino Calancha
2017-07-25 14:48 ` Eli Zaretskii
2017-07-26 7:57 ` Tino Calancha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8360eg7fhv.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=27817@debbugs.gnu.org \
--cc=tino.calancha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.