From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#27844: 26.0.50; Dired w/ eshell-ls doesn't support wildcards in file name Date: Tue, 01 Aug 2017 16:40:02 +0300 Message-ID: <8360e71k5p.fsf@gnu.org> References: <878tjasgom.fsf@calancha-pc> <87h8xyutc3.fsf@calancha-pc> <83inib393n.fsf@gnu.org> <87lgn4j8ko.fsf@calancha-pc> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1501594886 15565 195.159.176.226 (1 Aug 2017 13:41:26 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 1 Aug 2017 13:41:26 +0000 (UTC) Cc: 27844@debbugs.gnu.org To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Aug 01 15:41:20 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dcXQG-0003X4-5T for geb-bug-gnu-emacs@m.gmane.org; Tue, 01 Aug 2017 15:41:20 +0200 Original-Received: from localhost ([::1]:42616 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dcXQI-0002zk-Rb for geb-bug-gnu-emacs@m.gmane.org; Tue, 01 Aug 2017 09:41:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56132) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dcXQ7-0002yH-H4 for bug-gnu-emacs@gnu.org; Tue, 01 Aug 2017 09:41:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dcXQ2-0007L0-AC for bug-gnu-emacs@gnu.org; Tue, 01 Aug 2017 09:41:09 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33588) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dcXQ2-0007KH-66 for bug-gnu-emacs@gnu.org; Tue, 01 Aug 2017 09:41:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dcXPy-0005n0-GF for bug-gnu-emacs@gnu.org; Tue, 01 Aug 2017 09:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Aug 2017 13:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27844 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 27844-submit@debbugs.gnu.org id=B27844.150159482222199 (code B ref 27844); Tue, 01 Aug 2017 13:41:02 +0000 Original-Received: (at 27844) by debbugs.gnu.org; 1 Aug 2017 13:40:22 +0000 Original-Received: from localhost ([127.0.0.1]:36265 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dcXPK-0005ly-7n for submit@debbugs.gnu.org; Tue, 01 Aug 2017 09:40:22 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:36645) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dcXPG-0005lh-8R for 27844@debbugs.gnu.org; Tue, 01 Aug 2017 09:40:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dcXP7-0006mi-Qc for 27844@debbugs.gnu.org; Tue, 01 Aug 2017 09:40:13 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55330) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dcXP7-0006mK-ND; Tue, 01 Aug 2017 09:40:09 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4660 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dcXP6-0003mO-OG; Tue, 01 Aug 2017 09:40:09 -0400 In-reply-to: <87lgn4j8ko.fsf@calancha-pc> (message from Tino Calancha on Tue, 01 Aug 2017 12:00:39 +0900) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135212 Archived-At: > From: Tino Calancha > Cc: 27844@debbugs.gnu.org > Date: Tue, 01 Aug 2017 12:00:39 +0900 > > Eli Zaretskii writes: > > >> From: Tino Calancha > >> Date: Thu, 27 Jul 2017 18:23:08 +0900 > >> > >> `eshell-extended-glob' returns a list of matches on success, otherwise > >> it returns FILE; if no match i think we should signal an error. > > > > Whether this should be an error or just FILE is a matter of personal > > preferences, I think. Some shells behave this way, others the other > > way. So either we should leave your original patch as it was, or > > introduce a defcustom to produce an error if the user so wants. > Indeed such defcustom already does exist: eshell-error-if-no-glob > (default to nil). > You can see at the end of `eshell-extended-glob': > (if eshell-error-if-no-glob > (error "No matches found: %s" glob) > glob) I'm confused: I wasn't commenting on what eshell-extended-glob does, I was commenting about your code: + (let ((matches (eshell-extended-glob file))) + (if (consp matches) + (mapcar #'file-relative-name matches) + (user-error (format "%s: No files matching wildcard" file)))) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ If eshell-extended-glob already signals an error when it's TRT, why do you need to signal an error if Eshell doesn't? What am I missing? Thanks.