From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Why does make run git? Date: Wed, 02 Aug 2017 22:10:52 +0300 Message-ID: <8360e5zsxv.fsf@gnu.org> References: <83bmo00yw7.fsf@gnu.org> <6d947774-836a-7286-4214-ddc5f516577f@cs.ucla.edu> <83a83hzuqv.fsf@gnu.org> <02f6233d-b0ef-5a8f-9089-f3fc3496df02@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1501701166 6884 195.159.176.226 (2 Aug 2017 19:12:46 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 2 Aug 2017 19:12:46 +0000 (UTC) Cc: emacs-devel@gnu.org, rms@gnu.org, tino.calancha@gmail.com To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 02 21:12:42 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dcz4U-0001Tg-B2 for ged-emacs-devel@m.gmane.org; Wed, 02 Aug 2017 21:12:42 +0200 Original-Received: from localhost ([::1]:49867 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dcz4a-0002Bu-9f for ged-emacs-devel@m.gmane.org; Wed, 02 Aug 2017 15:12:48 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54879) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dcz3o-0002Bk-0w for emacs-devel@gnu.org; Wed, 02 Aug 2017 15:12:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dcz3k-00067L-Eu for emacs-devel@gnu.org; Wed, 02 Aug 2017 15:12:00 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60692) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dcz3k-00067A-Ao; Wed, 02 Aug 2017 15:11:56 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2559 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dcz3a-0003Ja-98; Wed, 02 Aug 2017 15:11:49 -0400 In-reply-to: <02f6233d-b0ef-5a8f-9089-f3fc3496df02@cs.ucla.edu> (message from Paul Eggert on Wed, 2 Aug 2017 11:42:43 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:217251 Archived-At: > Cc: rms@gnu.org, tino.calancha@gmail.com, emacs-devel@gnu.org > From: Paul Eggert > Date: Wed, 2 Aug 2017 11:42:43 -0700 > > On 08/02/2017 11:31 AM, Eli Zaretskii wrote: > >> To help improve the situation I propose the attached patch, which > >> reverts the default ./autogen.sh behavior to be './autogen.sh all', the > >> way it used to be (briefly). Developers who want autogen.sh to leave > >> their Git settings alone can continue to use './autogen.sh autoconf'. > > AFAIU, doing that will silently force the installation of the > > Git-related stuff when I run just "make", and Make decides it needs to > > invoke autogen.sh, because the fact that I originally used the > > non-default argument isn't recorded anywhere, and thus cannot be > > replayed. Right? > > No, if you run Make from a freshly-checked-out directory, Make calls > "./autogen.sh all", which sets up Git. The proposed patch doesn't affect > this. > > And if you run "./autogen.sh autoconf" and then run Make, Make won't set > up Git. The proposed patch doesn't affect this either. Maybe I'm confused, but top-level Makefile.in has this: $(srcdir)/configure: $(srcdir)/configure.ac $(srcdir)/m4/*.m4 cd $(srcdir) && ./autogen.sh This seems to say that if configure.ac or one of the *.m4 files become newer than configure, either because I edit them or because I just pulled from upstream, then Make will run "./autogen.sh", which under the default you propose will configure Git. If that's not true, then what am I missing?