From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#27986: 26.0.50; 'rename-file' can rename files without Date: Sat, 26 Aug 2017 10:30:57 +0300 Message-ID: <8360da7pla.fsf@gnu.org> References: <83wp5zc6c2.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1503732736 3386 195.159.176.226 (26 Aug 2017 07:32:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 26 Aug 2017 07:32:16 +0000 (UTC) Cc: 27986@debbugs.gnu.org, rms@gnu.org To: John Wiegley Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Aug 26 09:32:08 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dlVZe-0000SZ-F5 for geb-bug-gnu-emacs@m.gmane.org; Sat, 26 Aug 2017 09:32:06 +0200 Original-Received: from localhost ([::1]:56383 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dlVZl-0001XD-Ai for geb-bug-gnu-emacs@m.gmane.org; Sat, 26 Aug 2017 03:32:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54629) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dlVZe-0001Vu-AQ for bug-gnu-emacs@gnu.org; Sat, 26 Aug 2017 03:32:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dlVZb-0000mq-Ll for bug-gnu-emacs@gnu.org; Sat, 26 Aug 2017 03:32:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:47143) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dlVZb-0000mj-I0 for bug-gnu-emacs@gnu.org; Sat, 26 Aug 2017 03:32:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dlVZZ-0006nB-Qw for bug-gnu-emacs@gnu.org; Sat, 26 Aug 2017 03:32:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 26 Aug 2017 07:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27986 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: security Original-Received: via spool by 27986-submit@debbugs.gnu.org id=B27986.150373268926064 (code B ref 27986); Sat, 26 Aug 2017 07:32:01 +0000 Original-Received: (at 27986) by debbugs.gnu.org; 26 Aug 2017 07:31:29 +0000 Original-Received: from localhost ([127.0.0.1]:55822 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dlVZ3-0006mK-KO for submit@debbugs.gnu.org; Sat, 26 Aug 2017 03:31:29 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:35205) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dlVZ1-0006m6-SO for 27986@debbugs.gnu.org; Sat, 26 Aug 2017 03:31:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dlVYu-0000PF-70 for 27986@debbugs.gnu.org; Sat, 26 Aug 2017 03:31:22 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57004) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dlVYu-0000P9-3Y; Sat, 26 Aug 2017 03:31:20 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4346 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dlVYg-0002yO-Hl; Sat, 26 Aug 2017 03:31:07 -0400 In-reply-to: (message from John Wiegley on Fri, 25 Aug 2017 13:33:46 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:136218 Archived-At: > From: John Wiegley > Cc: rms@gnu.org, 27986@debbugs.gnu.org > Date: Fri, 25 Aug 2017 13:33:46 -0700 > > >>>>> "EZ" == Eli Zaretskii writes: > > EZ> Thanks. I do indeed think that making this an error even if B is an empty > EZ> directory would be better, as it will reveal the cases that need to be > EZ> fixed more prominently. > > I prefer that to renaming a directory when the target is a directory. That's > not how /bin/mv behaves, so I'd be surprised if (rename-file) did differently. > Making the Emacs version more restrictive, however, makes sense. Thanks. Paul, it sounds like we have a consensus on this, so please go ahead with the changes. At least Richard, John, and myself prefer to signal an error even when the target is an empty directory, so I hope the non-interactive rename-file could do that after your changes.