From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Suspicious warning in W64 build Date: Sun, 10 Sep 2017 17:40:55 +0300 Message-ID: <8360cqvcp4.fsf@gnu.org> References: <1017454172.910810.1504618695244@mail.libero.it> <83tw0ezgi1.fsf@gnu.org> <1146932094.13821.1504798935795@mail.libero.it> <83mv66z66p.fsf@gnu.org> <102a4c21-c275-c73e-ec53-0d85975dc968@cs.ucla.edu> <83a825znuf.fsf@gnu.org> <831snhzkgw.fsf@gnu.org> <837ex9x7vf.fsf@gnu.org> <83tw0cwcle.fsf@gnu.org> <83h8wcw3td.fsf@gnu.org> <83377vx3d0.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1505054547 2276 195.159.176.226 (10 Sep 2017 14:42:27 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 10 Sep 2017 14:42:27 +0000 (UTC) Cc: angelo.g0@libero.it, emacs-devel@gnu.org To: Richard Copley Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Sep 10 16:42:22 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dr3Qr-0007TB-EE for ged-emacs-devel@m.gmane.org; Sun, 10 Sep 2017 16:41:57 +0200 Original-Received: from localhost ([::1]:53220 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dr3Qt-0001LQ-UC for ged-emacs-devel@m.gmane.org; Sun, 10 Sep 2017 10:41:59 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46238) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dr3Pv-0001IK-9q for emacs-devel@gnu.org; Sun, 10 Sep 2017 10:41:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dr3Ps-0003Od-8O for emacs-devel@gnu.org; Sun, 10 Sep 2017 10:40:59 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33951) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dr3Ps-0003OT-56; Sun, 10 Sep 2017 10:40:56 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2738 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dr3Pq-0005g6-P7; Sun, 10 Sep 2017 10:40:56 -0400 In-reply-to: (message from Richard Copley on Sun, 10 Sep 2017 02:01:09 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:218089 Archived-At: > From: Richard Copley > Date: Sun, 10 Sep 2017 02:01:09 +0100 > Cc: Angelo Graziosi , Emacs Development > > > I expect others who use MinGW64 to care enough to report and fix these > > problems. > > I care and I'm encouraged by your words. I will do what I can. Thank you. > > CC frame.o > > frame.c: In function 'make_terminal_frame': > > frame.c:1098:46: warning: unknown conversion type character 'l' in format [-Wformat=] > > fset_name (f, make_formatted_string (name, "F%"pMd, ++tty_frame_count)); > > ^~~~ > > In file included from C:/msys64/mingw64/x86_64-w64-mingw32/include/inttypes.h:299:0, > > from C:/projects/emacs/nt/inc/inttypes.h:24, > > from lisp.h:31, > > from frame.c:29: > > C:/msys64/mingw64/x86_64-w64-mingw32/include/_mingw_print_pop.h:77:19: note: format string is defined here > > #define PRIdMAX "lld" > > ^ > > frame.c:1098:46: warning: too many arguments for format [-Wformat-extra-args] > > fset_name (f, make_formatted_string (name, "F%"pMd, ++tty_frame_count)); > > ^~~~ > > > > How come the compiler doesn't recognize format specifiers defined on > > the system headers? And note that as result GCC ignores some > > arguments of fset_name, which might mean it actually generates wrong > > code for this function. > > > > This should be taken up with MinGW64 developers ASAP, because I don't > > see how we can fix this in Emacs. > > I don't disagree. My impression is that Alexey and co. at MinGW-W64 > are well aware of it. I don't know if there's a solution in the > pipeline. I'm not the best person to press the point there (but ask me > one more time and I will try). I can write to them myself, if you tell me what would be the best forum to do so. > If you want, I will get you a transcript from the unpatched Emacs git > master branch as I should have done in the first place. No need for now. Let's try to fix the problems with formats first. There are also a few problems in unexw32.c, but they only affect debugging code, so it's not urgent to fix them (and the solution also involves format specifications).