all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Kaushal Modi <kaushal.modi@gmail.com>
Cc: nyraghu27132@gmail.com, johnw@gnu.org, emacs-devel@gnu.org
Subject: Re: pdf-view removed from mailcap.el
Date: Sun, 17 Sep 2017 18:37:40 +0300	[thread overview]
Message-ID: <8360chjpyz.fsf@gnu.org> (raw)
In-Reply-To: <CAFyQvY0m1afbtzasw7OW0eYaS72EJw56qw-0T8Wh2JA4MuZd3w@mail.gmail.com> (message from Kaushal Modi on Sun, 17 Sep 2017 14:59:16 +0000)

> From: Kaushal Modi <kaushal.modi@gmail.com>
> Date: Sun, 17 Sep 2017 14:59:16 +0000
> Cc: emacs-devel@gnu.org, johnw@gnu.org, nyraghu27132@gmail.com
> 
> It would be great if it is encouraged then. 

I think it already is, as we surely don't discourage that.

> If each committer makes sure to merge their commit, others don't have to review if they are merging others'
> commits correctly. I can talk of my experience in Org repo.. after my commits to the maint branch, all I need to
> do is check out master and do a merge.. as simple as this in Magit: "b b" (checkout master) "m m" (merge
> maint). 

It's not that easy in Emacs, see gitmerge.el and the references to it
in CONTRIBUTE.

> One doesn't need to be a "champion" as they are just making sure that their commit is landing in master too.

It's more complicated than that, unfortunately.  Even experienced
people made mistakes with that, so I guess it's not as easy as in
other projects.  Specific suggestions for how to make the process
better will be welcome, I'm sure, but please study the existing
documentation and code first.

> Would you consider documenting and at least recommending this flow?

What we thought needed to be documented is in CONTRIBUTE already.



      reply	other threads:[~2017-09-17 15:37 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-17 10:37 pdf-view removed from mailcap.el N. Raghavendra
2017-09-17 12:30 ` Mark Oteiza
2017-09-17 13:38   ` N. Raghavendra
2017-09-17 13:49     ` Óscar Fuentes
2017-09-17 14:13       ` N. Raghavendra
2017-09-17 14:39         ` Eli Zaretskii
2017-09-17 14:41           ` N. Raghavendra
2017-09-17 16:55             ` Eli Zaretskii
2017-09-17 18:27               ` N. Raghavendra
2017-09-17 19:00                 ` Eli Zaretskii
2017-09-17 13:52     ` Kaushal Modi
2017-09-17 14:37       ` Eli Zaretskii
2017-09-17 14:59         ` Kaushal Modi
2017-09-17 15:37           ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8360chjpyz.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=johnw@gnu.org \
    --cc=kaushal.modi@gmail.com \
    --cc=nyraghu27132@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.