From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24218: 25.1.50; server-name, server-socket-dir and daemon start through, systemd socket Date: Mon, 08 Jan 2018 05:50:25 +0200 Message-ID: <83608d80vy.fsf@gnu.org> References: <87popclj82.fsf@yandex.ru> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1515383359 24968 195.159.176.226 (8 Jan 2018 03:49:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 8 Jan 2018 03:49:19 +0000 (UTC) Cc: 24218@debbugs.gnu.org, matthew@mattleach.net, lomov.vl@gmail.com To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jan 08 04:49:15 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eYOQt-0005it-RM for geb-bug-gnu-emacs@m.gmane.org; Mon, 08 Jan 2018 04:49:07 +0100 Original-Received: from localhost ([::1]:34428 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eYOSt-0006ff-9g for geb-bug-gnu-emacs@m.gmane.org; Sun, 07 Jan 2018 22:51:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38627) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eYOSn-0006fY-8c for bug-gnu-emacs@gnu.org; Sun, 07 Jan 2018 22:51:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eYOSk-0002EA-73 for bug-gnu-emacs@gnu.org; Sun, 07 Jan 2018 22:51:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59624) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eYOSk-0002Du-3e for bug-gnu-emacs@gnu.org; Sun, 07 Jan 2018 22:51:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eYOSj-0007nX-Q0 for bug-gnu-emacs@gnu.org; Sun, 07 Jan 2018 22:51:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Jan 2018 03:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24218 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24218-submit@debbugs.gnu.org id=B24218.151538345529963 (code B ref 24218); Mon, 08 Jan 2018 03:51:01 +0000 Original-Received: (at 24218) by debbugs.gnu.org; 8 Jan 2018 03:50:55 +0000 Original-Received: from localhost ([127.0.0.1]:40072 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eYOSc-0007nC-W5 for submit@debbugs.gnu.org; Sun, 07 Jan 2018 22:50:55 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:47620) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eYOSb-0007mx-BG for 24218@debbugs.gnu.org; Sun, 07 Jan 2018 22:50:53 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eYOSS-00025s-2C for 24218@debbugs.gnu.org; Sun, 07 Jan 2018 22:50:47 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54009) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eYOSO-00022j-9y; Sun, 07 Jan 2018 22:50:40 -0500 Original-Received: from [176.228.60.248] (port=2785 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eYOSN-0000mx-JX; Sun, 07 Jan 2018 22:50:40 -0500 In-reply-to: (message from Paul Eggert on Sun, 7 Jan 2018 13:55:04 -0800) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:141889 Archived-At: > From: Paul Eggert > Date: Sun, 7 Jan 2018 13:55:04 -0800 > Cc: 24218@debbugs.gnu.org, Vladimir Lomov > > Matthew proposed a patch for this here: > > https://lists.gnu.org/r/emacs-devel/2017-12/msg00903.html > > which I am attaching in git form (see first attached patch). I also > propose the second attached patch as a followup. It makes some of the > newly-added features "private" (since they don't seem to be generally > useful) and moves the low-level initialization code from emacs.c to > process.c which is a more-natural home for it. Thanks. I'm not an expert on this stuff, so I have only minor comments: . Please update the :version tag of server-name, to reflect the fact that its default value changes . This needs a NEWS entry, and I think the description of server-name in the manual should be updated to mention this facility . internal--external-sockname should be documented in the ELisp manual (a better name that doesn't use both "internal" and "external" will be appreciated)