all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Noam Postavsky <npostavs@users.sourceforge.net>
Cc: 30243@debbugs.gnu.org, p.stephani2@gmail.com, michael.albinus@gmx.de
Subject: bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames
Date: Wed, 31 Jan 2018 18:02:06 +0200	[thread overview]
Message-ID: <83607if24h.fsf@gnu.org> (raw)
In-Reply-To: <87inbij3pr.fsf@users.sourceforge.net> (message from Noam Postavsky on Tue, 30 Jan 2018 19:01:52 -0500)

> From: Noam Postavsky <npostavs@users.sourceforge.net>
> Cc: Eli Zaretskii <eliz@gnu.org>,  30243@debbugs.gnu.org,  michael.albinus@gmx.de
> Date: Tue, 30 Jan 2018 19:01:52 -0500
> 
> Philipp Stephani <p.stephani2@gmail.com> writes:
> 
> > If my git bisect is correct, it was
> > commit a1bbc490155b61a634a6d0b165000ce35b93aa35 to fix Bug#29579. So
> > by fixing one bug we introduced another one :(
> 
> Actually, looking at Bug#29579 again, it doesn't seem *that* bad, and as
> far as I can tell, it has existed for a long time (still occurs back in
> 24.3).  So reverting that fix seems like a reasonable option too.  I can
> confirm that doing so fixes this bug.

I tend to agree.  Michael, WDYT?

> >     I also wonder how come we've succeeded to break quoted file names
> >     so fundamentally -- what change did that, and why did we make it
> >     on the release branch?
> 
> IMO, the root cause is pretty clearly lack of adequate tests for this.
> There are more than 60 file-handler operations; it's crazy to expect to
> be able to make a correct change without an automated test that at least
> exercises each one.

Right, thanks.

So if Michael agrees, I think we should revert the fix for bug#29579
on the release branch, and merge the branch you two worked on onto
master.





  reply	other threads:[~2018-01-31 16:02 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-24 22:12 bug#30243: 26.0.91; Infinite recursion in `make-auto-save-file-name' for quoted filenames phst
2018-01-24 22:43 ` Philipp Stephani
2018-01-24 23:04   ` Noam Postavsky
2018-01-24 23:25     ` Philipp Stephani
2018-01-25  5:57       ` Noam Postavsky
2018-01-25  9:49         ` Michael Albinus
2018-01-25 14:07           ` Noam Postavsky
2018-01-25 16:36             ` Michael Albinus
2018-01-25 16:46               ` Noam Postavsky
2018-01-26  1:46                 ` Noam Postavsky
2018-01-26 11:01                   ` Michael Albinus
2018-01-26 22:11                     ` Noam Postavsky
2018-01-28 10:28                       ` Michael Albinus
2018-01-28 14:58                         ` Noam Postavsky
2018-01-28 19:17                           ` Michael Albinus
2018-01-30 13:46                           ` Eli Zaretskii
2018-01-30 16:02                             ` Michael Albinus
2018-01-30 19:22                             ` Philipp Stephani
2018-01-31  0:01                               ` Noam Postavsky
2018-01-31 16:02                                 ` Eli Zaretskii [this message]
2018-01-31 18:07                                   ` Michael Albinus
2018-01-31 18:16                                     ` Noam Postavsky
2018-01-31 18:21                                       ` Michael Albinus
2018-02-01 14:01                                       ` Michael Albinus
2018-02-01 16:40                                         ` Philipp Stephani
2018-02-01 18:52                                           ` Michael Albinus
2018-02-02  1:16                                             ` Noam Postavsky
2018-02-02 17:56                                               ` Michael Albinus
2018-02-03 20:34                                                 ` Noam Postavsky
2018-01-31 15:38                               ` Eli Zaretskii
2018-02-16  3:38                   ` bug#30481: 26.0.91; infinite recursion + edebug = memory corruption Noam Postavsky
2018-02-16  8:39                     ` Eli Zaretskii
2018-02-17  3:30                       ` Noam Postavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83607if24h.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=30243@debbugs.gnu.org \
    --cc=michael.albinus@gmx.de \
    --cc=npostavs@users.sourceforge.net \
    --cc=p.stephani2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.