From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#30846: 26.0.91; debug-watch of kill-all-local-variables triggers 'assertion failed: found == !EQ (blv->defcell, blv->valcell)' Date: Fri, 23 Mar 2018 17:23:14 +0300 Message-ID: <83605mj2gd.fsf@gnu.org> References: <87sh8xttpq.fsf@gmail.com> <87in9nskw2.fsf@gmail.com> <83muyzi525.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1521814937 21580 195.159.176.226 (23 Mar 2018 14:22:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 23 Mar 2018 14:22:17 +0000 (UTC) Cc: npostavs@gmail.com, 30846@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 23 15:22:12 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezNa6-0005TU-Sn for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Mar 2018 15:22:10 +0100 Original-Received: from localhost ([::1]:38305 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ezNcA-0000Mf-7U for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Mar 2018 10:24:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34640) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ezNbz-0000LN-2K for bug-gnu-emacs@gnu.org; Fri, 23 Mar 2018 10:24:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ezNbu-0005NB-Ar for bug-gnu-emacs@gnu.org; Fri, 23 Mar 2018 10:24:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41944) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ezNbu-0005N4-6J for bug-gnu-emacs@gnu.org; Fri, 23 Mar 2018 10:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ezNbu-0005IF-0k for bug-gnu-emacs@gnu.org; Fri, 23 Mar 2018 10:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Mar 2018 14:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30846 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30846-submit@debbugs.gnu.org id=B30846.152181500220298 (code B ref 30846); Fri, 23 Mar 2018 14:24:01 +0000 Original-Received: (at 30846) by debbugs.gnu.org; 23 Mar 2018 14:23:22 +0000 Original-Received: from localhost ([127.0.0.1]:49841 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezNbG-0005HK-Je for submit@debbugs.gnu.org; Fri, 23 Mar 2018 10:23:22 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:43241) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezNbF-0005H8-Bi for 30846@debbugs.gnu.org; Fri, 23 Mar 2018 10:23:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ezNb6-0004uS-IW for 30846@debbugs.gnu.org; Fri, 23 Mar 2018 10:23:16 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56382) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ezNb6-0004uJ-Eb; Fri, 23 Mar 2018 10:23:12 -0400 Original-Received: from [176.228.60.248] (port=2536 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ezNb5-0001Zk-UH; Fri, 23 Mar 2018 10:23:12 -0400 In-reply-to: (message from Stefan Monnier on Fri, 23 Mar 2018 08:57:13 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144559 Archived-At: > From: Stefan Monnier > Cc: Noam Postavsky , 30846@debbugs.gnu.org > Date: Fri, 23 Mar 2018 08:57:13 -0400 > > >> > If you feel this is too risky for emacs-26, I wouldn't blame you (this > >> > is pretty tricky code): while the assertion crashes Emacs, a normal > >> > build without assertions will likely not notice the problem at all. > >> > I came up with a test case that catches the problem, but I think that in > >> > "real" life it's very unlikely to cause a problem. > >> Should we disable the assertion in emacs-26 then? > > Do we believe people build a production version with --enable-checking? > > Does that mean you'd rather not install my patch into emacs-26 or are > you still undecided? I'm quite sure we shouldn't put this on emacs-26, I was just replying to Noam's suggestion to remove the assertion.