From: Eli Zaretskii <eliz@gnu.org>
To: Philipp Stephani <p.stephani2@gmail.com>
Cc: jixiuf@qq.com, emacs-devel@gnu.org
Subject: Re: make pred customable in auto-save-visited-mode
Date: Sat, 31 Mar 2018 13:45:24 +0300 [thread overview]
Message-ID: <83605c8qwr.fsf@gnu.org> (raw)
In-Reply-To: <CAArVCkQForXTEChFY1WeBTe76bbBYDijqu3cugX-0e636grX8Q@mail.gmail.com> (message from Philipp Stephani on Sat, 31 Mar 2018 10:28:58 +0000)
> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Sat, 31 Mar 2018 10:28:58 +0000
> Cc: 纪秀峰 <jixiuf@qq.com>, emacs-devel@gnu.org
>
> I agree that customization isn't the best solution here. However, I'm suprised that `save-some-buffers'
> still prompts even if :noprompt is passed.
> The issue might be in `save-some-buffers': Its docstring says "If PRED is t, then certain non-file buffers
> will also be considered.", but later it only checks whether PRED is non-nil:
>
> (or
> (buffer-file-name buffer)
> (with-current-buffer buffer
> (or (eq buffer-offer-save 'always)
> (and pred buffer-offer-save (> (buffer-size) 0)))))
>
> Maybe instead of `pred' here we should say (eq pred t). Alternative, the predicate lambda should check
> whether `buffer-file-name' is non-nil.
>
> Probably the second option is better because the first option would prevent PRED from running for
> non-file-visiting buffers. Patch attached.
AFAIU, this will unconditionally disable auto-saving in *ediff-merge*
and all the similar buffers, when auto-save-visited-mode is turned
on. Is that what we want? And if that's going to be the default, how
are users supposed to override it if they want?
next prev parent reply other threads:[~2018-03-31 10:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-30 16:59 make pred customable in auto-save-visited-mode 纪秀峰
2018-03-31 8:43 ` Eli Zaretskii
2018-03-31 10:23 ` Philipp Stephani
2018-03-31 10:28 ` Philipp Stephani
2018-03-31 10:45 ` Eli Zaretskii [this message]
2018-04-01 17:19 ` Philipp Stephani
2018-04-01 17:35 ` Eli Zaretskii
2018-04-01 19:51 ` Philipp Stephani
2018-04-02 4:44 ` Eli Zaretskii
2018-04-02 10:20 ` Philipp Stephani
2018-03-31 10:42 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83605c8qwr.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=jixiuf@qq.com \
--cc=p.stephani2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.