From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 1/3] Document that 'make-process' mixes the output streams Date: Wed, 04 Apr 2018 16:12:33 +0300 Message-ID: <8360573yke.fsf@gnu.org> References: <20180404120218.257212-1-phst@google.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1522847436 28812 195.159.176.226 (4 Apr 2018 13:10:36 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 4 Apr 2018 13:10:36 +0000 (UTC) Cc: phst@google.com, emacs-devel@gnu.org To: Philipp Stephani Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 04 15:10:32 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f3iBK-0007O8-Us for ged-emacs-devel@m.gmane.org; Wed, 04 Apr 2018 15:10:31 +0200 Original-Received: from localhost ([::1]:57388 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f3iDQ-0005ax-B5 for ged-emacs-devel@m.gmane.org; Wed, 04 Apr 2018 09:12:40 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59420) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f3iDG-0005ZJ-Cx for emacs-devel@gnu.org; Wed, 04 Apr 2018 09:12:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f3iDF-0006uw-KG for emacs-devel@gnu.org; Wed, 04 Apr 2018 09:12:30 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39794) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f3iD9-0006tm-M9; Wed, 04 Apr 2018 09:12:23 -0400 Original-Received: from [176.228.60.248] (port=4707 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1f3iD9-0004v0-1G; Wed, 04 Apr 2018 09:12:23 -0400 In-reply-to: <20180404120218.257212-1-phst@google.com> (message from Philipp Stephani on Wed, 4 Apr 2018 14:02:16 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:224316 Archived-At: > From: Philipp Stephani > Date: Wed, 4 Apr 2018 14:02:16 +0200 > Cc: Philipp Stephani > > * doc/lispref/processes.texi (Asynchronous Processes): > * src/process.c (Fmake_process): Document that standard error is mixed > with standard output if STDERR is nil. Thanks. > +(ert-deftest make-process/mix-stderr () > + "Check that ‘make-process’ mixes the output streams if STDERR is nil." > + (skip-unless (executable-find shell-file-name)) > + (with-temp-buffer > + (let ((process (make-process > + :name "mix-stderr" > + :command (list shell-file-name shell-command-switch > + "echo stdout; echo stderr >&2") ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ This shell command is non-portable: on Windows you have to use "&" instead of ";" to chain commands. You could use "&&", which in this case will do the same on both Posix and Windows systems.