From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#31446: 26.1; sql-interactive-mode buffer naming is broken Date: Mon, 21 May 2018 18:45:42 +0300 Message-ID: <83603hf1w9.fsf@gnu.org> References: <83d0xti993.fsf@gnu.org> <83bmddi2ad.fsf@gnu.org> <83603lhrvw.fsf@gnu.org> <8336yoiuf4.fsf@gnu.org> <831se6hjnh.fsf@gnu.org> <83h8n1g2hm.fsf@gnu.org> <42fe26038dde2b56636888cfbf4e37bb@webmail.orcon.net.nz> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1526917448 12013 195.159.176.226 (21 May 2018 15:44:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 21 May 2018 15:44:08 +0000 (UTC) Cc: 31446@debbugs.gnu.org, fgunbin@fastmail.fm, bug-gnu-emacs-bounces+psainty=orcon.net.nz@gnu.org, michael@mauger.com To: Phil Sainty Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 21 17:44:04 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fKmyh-0002x8-3z for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 May 2018 17:44:03 +0200 Original-Received: from localhost ([::1]:51246 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fKn0m-0000Jx-LX for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 May 2018 11:46:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36555) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fKn0c-0000CK-NR for bug-gnu-emacs@gnu.org; Mon, 21 May 2018 11:46:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fKn0b-0001gd-RG for bug-gnu-emacs@gnu.org; Mon, 21 May 2018 11:46:02 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35265) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fKn0b-0001gV-Ne for bug-gnu-emacs@gnu.org; Mon, 21 May 2018 11:46:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fKn0b-0002IP-Hj for bug-gnu-emacs@gnu.org; Mon, 21 May 2018 11:46:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 May 2018 15:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31446 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31446-submit@debbugs.gnu.org id=B31446.15269175598816 (code B ref 31446); Mon, 21 May 2018 15:46:01 +0000 Original-Received: (at 31446) by debbugs.gnu.org; 21 May 2018 15:45:59 +0000 Original-Received: from localhost ([127.0.0.1]:43162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fKn0X-0002I4-ST for submit@debbugs.gnu.org; Mon, 21 May 2018 11:45:59 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:45523) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fKn0W-0002Hs-Ip for 31446@debbugs.gnu.org; Mon, 21 May 2018 11:45:56 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fKn0Q-0001cO-HK for 31446@debbugs.gnu.org; Mon, 21 May 2018 11:45:51 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54345) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fKn0G-0001YM-5m; Mon, 21 May 2018 11:45:40 -0400 Original-Received: from [176.228.60.248] (port=2945 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fKn0F-0006QC-K4; Mon, 21 May 2018 11:45:40 -0400 In-reply-to: <42fe26038dde2b56636888cfbf4e37bb@webmail.orcon.net.nz> (message from Phil Sainty on Tue, 22 May 2018 00:09:36 +1200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:146352 Archived-At: > Date: Tue, 22 May 2018 00:09:36 +1200 > From: Phil Sainty > Cc: 31446@debbugs.gnu.org, fgunbin@fastmail.fm, bug-gnu-emacs > , "Michael R. Mauger" > > > (eq new-name '(4)) is never true, so it falls through to > (format "*SQL: %s*" new-name) when a prefix arg is supplied. Right, thanks. > I *think* we'd want (consp new-name) for that test (especially as > it ought to cover multiple uses of C-u), *however* doing this then > triggers error "Current buffer is not a SQL interactive buffer" in > `sql-rename-buffer', as this is happening *before* the call to the > :sqli-comint-func function which creates the buffer. Right, so we need to pull the relevant stuff out of that function. > I've briefly tested Filipp's suggestion, but that seemed to result in > just *SQL* as a buffer name regardless of the prefix argument, rather > than causing it to prompt for the name (however that might turn out to > be sane in conjunction with the additional changes I've made below?) > > The following is working from initial/cursory testing, but it needs > more testing/confirmation at minimum. Thanks, I tried fixing it in a slightly different way, please take a look. I'd like to avoid releasing Emacs 26.1 with sql.el that was broken by latest changes.