all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: Message's text-properties in *Messages*
Date: Wed, 23 May 2018 21:07:37 +0300	[thread overview]
Message-ID: <83603eckk6.fsf@gnu.org> (raw)
In-Reply-To: <jwvtvqyb7p7.fsf-monnier+gmane.emacs.devel@gnu.org> (message from Stefan Monnier on Wed, 23 May 2018 13:41:36 -0400)

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Wed, 23 May 2018 13:41:36 -0400
> 
> >> - Why would arbitrary Lisp code be dangerous (I understand that message_dolog
> >>   can be called from within redisplay, but redisplay runs Elisp code
> >>   at several places, so "from redisplay" doesn't inherently imply you
> >>   can't run Elisp code).
> > When Lisp code is called from redisplay, we always do that via
> > safe_call.  Anything else is not safe, AFAIR.
> 
> I see.  This doesn't answer all the questions, tho:

I didn't mean to answer all of them yet, I will need some time to look
at the code.  However, one other thing is pretty much clear:

> - The current code still does
> 
>     call0 (intern ("messages-buffer-mode"));
> 
>   hence doesn't use safe_call here.

This is called in message_dolog, which doesn't enter redisplay.
Redisplay is triggered in message3_nolog.  So maybe we are mixing two
different issues here, and that comment is not about redisplay at all.
If I'm right, there's no issue with calling Lisp from message_dolog
per se.



  reply	other threads:[~2018-05-23 18:07 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-21 17:10 edebug: regrettable loss of information in Emacs 26.1 when printing a variable's value Alan Mackenzie
2018-05-21 17:47 ` Noam Postavsky
2018-05-21 18:23   ` Alan Mackenzie
2018-05-21 18:30   ` Eli Zaretskii
2018-05-21 21:20     ` Noam Postavsky
2018-05-22 16:53       ` Eli Zaretskii
2018-05-21 17:58 ` Eli Zaretskii
2018-05-21 19:04   ` Alan Mackenzie
2018-05-21 18:05 ` Stefan Monnier
2018-05-21 21:24   ` Noam Postavsky
2018-05-22  0:52     ` Stefan Monnier
2018-05-23 17:28       ` Stefan Monnier
2018-05-23 16:03     ` Message's text-properties in *Messages* (was: edebug: regrettable loss of information in Emacs 26.1 when printing a variable's value) Stefan Monnier
2018-05-23 16:10       ` Drew Adams
2018-05-23 16:46         ` Message's text-properties in *Messages* Stefan Monnier
2018-05-26  0:48           ` John Wiegley
2018-05-26 15:52             ` Stefan Monnier
2018-05-26 19:50               ` Amin Bandali
2018-05-27 14:36                 ` John Wiegley
2018-05-27 21:28                   ` Amin Bandali
2018-05-23 17:22       ` Message's text-properties in *Messages* (was: edebug: regrettable loss of information in Emacs 26.1 when printing a variable's value) Eli Zaretskii
2018-05-23 17:41         ` Message's text-properties in *Messages* Stefan Monnier
2018-05-23 18:07           ` Eli Zaretskii [this message]
2018-05-30 17:19             ` Eli Zaretskii
2018-05-30 19:44               ` Stefan Monnier
2018-05-30 19:55                 ` Eli Zaretskii
2018-05-31  2:09                   ` Stefan Monnier
2018-05-31  2:40                     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83603eckk6.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.