From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>, Kenichi Handa <handa@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] emacs-26 0feb673: Display raw bytes as belonging to 'eight-bit' charset
Date: Fri, 27 Jul 2018 16:53:21 +0300 [thread overview]
Message-ID: <836010ss32.fsf@gnu.org> (raw)
In-Reply-To: <jwvwotgrh28.fsf-monnier+emacsdiffs@gnu.org> (message from Stefan Monnier on Fri, 27 Jul 2018 08:38:56 -0400)
> From: Stefan Monnier <monnier@IRO.UMontreal.CA>
> Date: Fri, 27 Jul 2018 08:38:56 -0400
> Cc: Eli Zaretskii <eliz@gnu.org>
>
> > (char-charset char))))
> > + ;; TIS620.2533 overlaps eight-bit-control, but we want to
> > + ;; show eight-bit for raw bytes, not some obscure character
> > + ;; set no one heard of.
> > + (charset (if (eq charset 'tis620-2533)
> > + 'eight-bit
> > + charset))
>
> Do we need `char-charset` to return `tis620-2533` for these, or could we
> instead of the above change `char-charset` to return `eight-bit` or
> `eight-bit-control`?
I don't know, because I don't understand why in this situation we
return tis620-2533 instead of eight-bit. Maybe it's intended, and
maybe it's just a side effect of how we implement char-charset.
The above change is safe, more-or-less, because it only affects how we
display information about characters. Making an equivalent change
inside char-charset would affect all users of that API.
prev parent reply other threads:[~2018-07-27 13:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180727064907.6305.13029@vcs0.savannah.gnu.org>
[not found] ` <20180727064909.85288203C0@vcs0.savannah.gnu.org>
2018-07-27 12:38 ` [Emacs-diffs] emacs-26 0feb673: Display raw bytes as belonging to 'eight-bit' charset Stefan Monnier
2018-07-27 13:10 ` Robert Pluim
2018-07-27 13:46 ` Eli Zaretskii
2018-07-27 15:00 ` Andreas Schwab
2018-07-27 17:54 ` Eli Zaretskii
2018-07-27 17:59 ` Andreas Schwab
2018-07-27 20:50 ` Eli Zaretskii
2018-07-27 19:03 ` Stefan Monnier
2018-07-27 21:04 ` Eli Zaretskii
2018-07-28 14:15 ` Stefan Monnier
2018-07-28 15:15 ` Eli Zaretskii
2018-07-28 16:49 ` Stefan Monnier
2018-07-28 17:37 ` Eli Zaretskii
2018-07-28 7:53 ` Andreas Schwab
2018-07-27 13:53 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=836010ss32.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=handa@gnu.org \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.