From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Some vars now limited to fixnum size. (Was: Merging bignum to master) Date: Mon, 20 Aug 2018 20:25:05 +0300 Message-ID: <836005dk7i.fsf@gnu.org> References: <877ekwu1mn.fsf@tromey.com> <611579fd-52f2-0104-ef82-a7a4a3929700@cs.ucla.edu> <878t51t32a.fsf_-_@red-bean.com> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1534785851 30617 195.159.176.226 (20 Aug 2018 17:24:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 20 Aug 2018 17:24:11 +0000 (UTC) Cc: eggert@cs.ucla.edu, tom@tromey.com, pipcet@gmail.com, emacs-devel@gnu.org To: Karl Fogel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 20 19:24:07 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1frnuQ-0007rV-S7 for ged-emacs-devel@m.gmane.org; Mon, 20 Aug 2018 19:24:06 +0200 Original-Received: from localhost ([::1]:48310 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1frnwX-0006T6-Ao for ged-emacs-devel@m.gmane.org; Mon, 20 Aug 2018 13:26:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51672) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1frnvS-0006Jo-2T for emacs-devel@gnu.org; Mon, 20 Aug 2018 13:25:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1frnvR-0001Km-FW for emacs-devel@gnu.org; Mon, 20 Aug 2018 13:25:10 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:38518) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1frnvR-0001Ka-7D; Mon, 20 Aug 2018 13:25:09 -0400 Original-Received: from [176.228.60.248] (port=4284 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1frnvQ-0005wx-Nm; Mon, 20 Aug 2018 13:25:09 -0400 In-reply-to: <878t51t32a.fsf_-_@red-bean.com> (message from Karl Fogel on Mon, 20 Aug 2018 11:28:45 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:228751 Archived-At: > From: Karl Fogel > Date: Mon, 20 Aug 2018 11:28:45 -0500 > Cc: tom@tromey.com, Pip Cet , emacs-devel@gnu.org > > On 'master' as of commit ecd7a94077, if you do this: > > (setq mark-ring-max (1+ most-positive-fixnum)) > > then any command that calls `push-mark' will raise an error: > > Wrong type argument: fixnump, 2305843009213693952 > > (Lots of common commands do, obviously: `beginning-of-buffer', `yank', etc.) > > The root cause is in `nthcdr', which now requires a fixnum for its first argument, although this requirement is not documented: > > DEFUN ("nthcdr", Fnthcdr, Snthcdr, 2, 2, 0, > doc: /* Take cdr N times on LIST, return the result. */) > (Lisp_Object n, Lisp_Object list) > { > CHECK_FIXNUM (n); > [...] > } > > Should we document this? Yes, I think so.