From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#33450: 26.1.90; NEWS entry for dired 'Z' is inaccurate Date: Wed, 21 Nov 2018 11:23:17 +0200 Message-ID: <835zwqiy2i.fsf@gnu.org> References: <32297.1542771545@alto> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1542792136 21266 195.159.176.226 (21 Nov 2018 09:22:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 21 Nov 2018 09:22:16 +0000 (UTC) Cc: 33450@debbugs.gnu.org To: Mike Kupfer Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 21 10:22:12 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gPOi2-0005Mk-M3 for geb-bug-gnu-emacs@m.gmane.org; Wed, 21 Nov 2018 10:22:10 +0100 Original-Received: from localhost ([::1]:37959 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPOk9-00075f-7S for geb-bug-gnu-emacs@m.gmane.org; Wed, 21 Nov 2018 04:24:21 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37514) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPOjw-00075N-Tc for bug-gnu-emacs@gnu.org; Wed, 21 Nov 2018 04:24:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gPOjs-0006Pw-0c for bug-gnu-emacs@gnu.org; Wed, 21 Nov 2018 04:24:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33526) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gPOjr-0006PV-Rd for bug-gnu-emacs@gnu.org; Wed, 21 Nov 2018 04:24:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gPOjq-0005WZ-06 for bug-gnu-emacs@gnu.org; Wed, 21 Nov 2018 04:24:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Nov 2018 09:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33450 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33450-submit@debbugs.gnu.org id=B33450.154279219921183 (code B ref 33450); Wed, 21 Nov 2018 09:24:01 +0000 Original-Received: (at 33450) by debbugs.gnu.org; 21 Nov 2018 09:23:19 +0000 Original-Received: from localhost ([127.0.0.1]:37784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gPOj9-0005Vb-8O for submit@debbugs.gnu.org; Wed, 21 Nov 2018 04:23:19 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:55936) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gPOj8-0005VP-DH for 33450@debbugs.gnu.org; Wed, 21 Nov 2018 04:23:18 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gPOiy-0005s1-Eu for 33450@debbugs.gnu.org; Wed, 21 Nov 2018 04:23:13 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42836) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPOix-0005q5-II; Wed, 21 Nov 2018 04:23:08 -0500 Original-Received: from [176.228.60.248] (port=4041 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gPOix-0002GR-5b; Wed, 21 Nov 2018 04:23:07 -0500 In-reply-to: <32297.1542771545@alto> (message from Mike Kupfer on Tue, 20 Nov 2018 19:39:05 -0800) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152623 Archived-At: > From: Mike Kupfer > Date: Tue, 20 Nov 2018 19:39:05 -0800 > > The 26.1.90 NEWS file has this (new) entry for Dired: > > *** The 'Z' command on a directory name compresses all of its files. > It produces a compressed '.tar.gz' archive with all the files in the > directory and all of its subdirectories. For symmetry, 'Z' on a > '.tar.gz' or a '.tgz' archive extracts all the archived files into a > directory whose name is the archive name sans the '.tar.gz' or '.tgz' > extension. (This change was actually made in Emacs 26.1, but was not > called out in its NEWS.) > > The description of the unpacking case implies that the user will see the > described behavior for any .tar.gz or .tgz file. In reality, 'Z' simply > unpacks the archive. The described behavior only happens if the archive > is structured in a canonical way, e.g., if 'Z' was used to create the > .tar.gz file. > > The wording should be changed, so as not to mislead the user about what > 'Z' does. A user who misunderstands what 'Z' does could lose data due > to unanticipated overwrite when the archive is unpacked. (Note that the > docstring for dired-do-compress says nothing about creating or unpacking > archive files.) I don't think I understand. Are you alluding to the case when the archive includes absolute file names, or file names that raise above the directory where the archive lives? Or do you have some other case in mind? > Also, and less important, I got the impression from the discussion on > emacs-devel that this feature was partially introduced in Emacs 25. > Wasn't the change in 26.1 just to make .tar.gz and .tgz behave the same? > I'm not sure it's worth trying to be that precise in the NEWS entry, but > I thought I'd mention it. You mean, say that some of the feature was available since Emacs 25? I don't think it's important, no.