From: Eli Zaretskii <eliz@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: 33650@debbugs.gnu.org
Subject: bug#33650: 27.0.50; Root diffs between revisions
Date: Sun, 09 Dec 2018 10:22:01 +0200 [thread overview]
Message-ID: <835zw33yae.fsf@gnu.org> (raw)
In-Reply-To: <87va431t6w.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 09 Dec 2018 01:32:47 +0200)
> From: Juri Linkov <juri@linkov.net>
> Cc: 33650@debbugs.gnu.org
> Date: Sun, 09 Dec 2018 01:32:47 +0200
>
> > I also wonder what would this mean for a VCS such as CVS or RCS, where
> > there's no meaning of a "tree revision". I'm guessing this is why the
> > old code deduced files to diff. See also the description of vc-diff
> > in the Emacs manual.
>
> `vc-root-diff' is not applicable to VCS without tree revisions, and
> the manual says nothing about this. Maybe the manual should say this
> explicitly for `vc-root-diff' as it says it for `vc-print-root-log'
> in (info "(emacs) VC Change Log")
Yes, we should say that.
> > Finally, we need documentation changes to go with this change of
> > user-visible behavior.
>
> This feature is already documented in (info "(emacs) Old Revisions")
>
> ‘C-x v D’
> Compare the entire working tree to the revision you started from
> (‘vc-root-diff’). With a prefix argument, prompt for two revisions
> and compare their trees.
>
> It didn't work as documented before properly implemented by the patch.
Isn't the result user-visible change in behavior?
> (defun vc-version-diff (_files rev1 rev2)
> - "Report diffs between revisions of the fileset in the repository history."
> + "Report diffs between revisions of the fileset in the repository history.
> +REV1 is an older revision, REV2 is a newer revision."
We usually mention the arguments in the first line of the doc string.
Something like this:
Report diffs between revisions REV1 and REV2 in the repository history.
I wonder whether "fileset" needs to be mentioned at all, given your
changes. When does any "fileset" come into play here?
> +(defun vc-root-version-diff (_files rev1 rev2)
> + "Report diffs between revisions of the whole tree in the repository history.
> +REV1 is an older revision, REV2 is a newer revision."
Same here: please mention the arguments in the first sentence.
> + (if backend
> + (setq rootdir (vc-call-backend backend 'root default-directory))
There's a TAB at the beginning of this line which should be spaces.
Thanks.
next prev parent reply other threads:[~2018-12-09 8:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 21:54 bug#33650: 27.0.50; Root diffs between revisions Juri Linkov
2018-12-07 6:41 ` Eli Zaretskii
2018-12-08 23:32 ` Juri Linkov
2018-12-09 8:22 ` Eli Zaretskii [this message]
2018-12-10 0:04 ` Juri Linkov
2018-12-10 0:59 ` Dmitry Gutov
2018-12-10 6:30 ` Eli Zaretskii
2018-12-10 23:55 ` Juri Linkov
2018-12-10 6:29 ` Eli Zaretskii
2018-12-10 23:55 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=835zw33yae.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=33650@debbugs.gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.