* bug#33694: 27.0.50; 'set-window-scroll-bars' broken
@ 2018-12-10 8:41 martin rudalics
2018-12-10 9:52 ` Eli Zaretskii
0 siblings, 1 reply; 9+ messages in thread
From: martin rudalics @ 2018-12-10 8:41 UTC (permalink / raw)
To: 33694; +Cc: monnier
This change
2015-09-30 Stefan Monnier <monnier@iro.umontreal.ca>
Try to avoid redisplaying all frames when creating a new one
...
* src/window.c (apply_window_adjustment): Remove redundant setting of
windows_or_buffers_changed.
...
broke evaluating the following form with emacs -Q:
(set-window-scroll-bars nil 0 nil)
This should immediately remove the scroll bar of the selected window
but instead hides its right fringe under the scroll bar.
martin
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#33694: 27.0.50; 'set-window-scroll-bars' broken
2018-12-10 8:41 bug#33694: 27.0.50; 'set-window-scroll-bars' broken martin rudalics
@ 2018-12-10 9:52 ` Eli Zaretskii
2018-12-10 17:44 ` martin rudalics
0 siblings, 1 reply; 9+ messages in thread
From: Eli Zaretskii @ 2018-12-10 9:52 UTC (permalink / raw)
To: martin rudalics; +Cc: 33694, monnier
> Date: Mon, 10 Dec 2018 09:41:11 +0100
> From: martin rudalics <rudalics@gmx.at>
> Cc: monnier@iro.umontreal.ca
>
> This change
>
> 2015-09-30 Stefan Monnier <monnier@iro.umontreal.ca>
>
> Try to avoid redisplaying all frames when creating a new one
>
> ...
>
> * src/window.c (apply_window_adjustment): Remove redundant setting of
> windows_or_buffers_changed.
>
> ...
>
> broke evaluating the following form with emacs -Q:
>
> (set-window-scroll-bars nil 0 nil)
>
> This should immediately remove the scroll bar of the selected window
> but instead hides its right fringe under the scroll bar.
Does the below look reasonable? I'd like to apply it to the emacs-26
branch.
diff --git a/src/window.c b/src/window.c
index 5d99098..c93ab5c 100644
--- a/src/window.c
+++ b/src/window.c
@@ -7254,6 +7254,10 @@ set_window_scroll_bars (struct window *w, Lisp_Object width,
wset_horizontal_scroll_bar_type (w, Qnil);
#endif
+ /* This is needed to trigger immediate redisplay of the window when
+ scroll bars are changed. */
+ if (changed)
+ windows_or_buffers_changed = 31;
return changed ? w : NULL;
}
^ permalink raw reply related [flat|nested] 9+ messages in thread
* bug#33694: 27.0.50; 'set-window-scroll-bars' broken
2018-12-10 9:52 ` Eli Zaretskii
@ 2018-12-10 17:44 ` martin rudalics
2018-12-10 18:09 ` Eli Zaretskii
0 siblings, 1 reply; 9+ messages in thread
From: martin rudalics @ 2018-12-10 17:44 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 33694, monnier
> Does the below look reasonable? I'd like to apply it to the emacs-26
> branch.
Hmm... 'set-window-fringes' has the same problem.
martin
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#33694: 27.0.50; 'set-window-scroll-bars' broken
2018-12-10 17:44 ` martin rudalics
@ 2018-12-10 18:09 ` Eli Zaretskii
2018-12-11 8:34 ` martin rudalics
0 siblings, 1 reply; 9+ messages in thread
From: Eli Zaretskii @ 2018-12-10 18:09 UTC (permalink / raw)
To: martin rudalics; +Cc: 33694, monnier
> Date: Mon, 10 Dec 2018 18:44:38 +0100
> From: martin rudalics <rudalics@gmx.at>
> CC: 33694@debbugs.gnu.org, monnier@iro.umontreal.ca
>
> > Does the below look reasonable? I'd like to apply it to the emacs-26
> > branch.
>
> Hmm... 'set-window-fringes' has the same problem.
I can do the same there. Anything else?
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#33694: 27.0.50; 'set-window-scroll-bars' broken
2018-12-10 18:09 ` Eli Zaretskii
@ 2018-12-11 8:34 ` martin rudalics
2018-12-11 8:43 ` Eli Zaretskii
0 siblings, 1 reply; 9+ messages in thread
From: martin rudalics @ 2018-12-11 8:34 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 33694, monnier
>> Hmm... 'set-window-fringes' has the same problem.
>
> I can do the same there. Anything else?
Since IIUC margins are handled differently I see no further issues.
Thanks for fixing these, martin
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#33694: 27.0.50; 'set-window-scroll-bars' broken
2018-12-11 8:34 ` martin rudalics
@ 2018-12-11 8:43 ` Eli Zaretskii
2018-12-11 9:05 ` martin rudalics
0 siblings, 1 reply; 9+ messages in thread
From: Eli Zaretskii @ 2018-12-11 8:43 UTC (permalink / raw)
To: martin rudalics; +Cc: 33694, monnier
> Date: Tue, 11 Dec 2018 09:34:57 +0100
> From: martin rudalics <rudalics@gmx.at>
> CC: 33694@debbugs.gnu.org, monnier@iro.umontreal.ca
>
> >> Hmm... 'set-window-fringes' has the same problem.
> >
> > I can do the same there. Anything else?
>
> Since IIUC margins are handled differently I see no further issues.
OK, but can you give me a recipe for set-window-fringes? In my
testing, the fringes are updated instantly after the call.
Thanks.
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#33694: 27.0.50; 'set-window-scroll-bars' broken
2018-12-11 8:43 ` Eli Zaretskii
@ 2018-12-11 9:05 ` martin rudalics
2018-12-11 10:33 ` Eli Zaretskii
0 siblings, 1 reply; 9+ messages in thread
From: martin rudalics @ 2018-12-11 9:05 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 33694, monnier
> OK, but can you give me a recipe for set-window-fringes? In my
> testing, the fringes are updated instantly after the call.
When on the release branch with emacs -Q I evaluate
(set-window-fringes nil 40 60)
in *scratch* I don't see any change. After moving the cursor I do.
martin
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#33694: 27.0.50; 'set-window-scroll-bars' broken
2018-12-11 9:05 ` martin rudalics
@ 2018-12-11 10:33 ` Eli Zaretskii
2018-12-12 8:30 ` martin rudalics
0 siblings, 1 reply; 9+ messages in thread
From: Eli Zaretskii @ 2018-12-11 10:33 UTC (permalink / raw)
To: martin rudalics; +Cc: 33694-done, monnier
> Date: Tue, 11 Dec 2018 10:05:41 +0100
> From: martin rudalics <rudalics@gmx.at>
> CC: 33694@debbugs.gnu.org, monnier@iro.umontreal.ca
>
> > OK, but can you give me a recipe for set-window-fringes? In my
> > testing, the fringes are updated instantly after the call.
>
> When on the release branch with emacs -Q I evaluate
>
> (set-window-fringes nil 40 60)
>
> in *scratch* I don't see any change. After moving the cursor I do.
Thanks, I pushed the changes to the emacs-26 branch.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-12-12 8:30 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-10 8:41 bug#33694: 27.0.50; 'set-window-scroll-bars' broken martin rudalics
2018-12-10 9:52 ` Eli Zaretskii
2018-12-10 17:44 ` martin rudalics
2018-12-10 18:09 ` Eli Zaretskii
2018-12-11 8:34 ` martin rudalics
2018-12-11 8:43 ` Eli Zaretskii
2018-12-11 9:05 ` martin rudalics
2018-12-11 10:33 ` Eli Zaretskii
2018-12-12 8:30 ` martin rudalics
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.