all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: 33694@debbugs.gnu.org, monnier@iro.umontreal.ca
Subject: bug#33694: 27.0.50; 'set-window-scroll-bars' broken
Date: Mon, 10 Dec 2018 11:52:57 +0200	[thread overview]
Message-ID: <835zw13dza.fsf@gnu.org> (raw)
In-Reply-To: <5C0E26A7.4070104@gmx.at> (message from martin rudalics on Mon, 10 Dec 2018 09:41:11 +0100)

> Date: Mon, 10 Dec 2018 09:41:11 +0100
> From: martin rudalics <rudalics@gmx.at>
> Cc: monnier@iro.umontreal.ca
> 
> This change
> 
> 2015-09-30  Stefan Monnier  <monnier@iro.umontreal.ca>
> 
> 	Try to avoid redisplaying all frames when creating a new one
> 
> 	...
> 
> 	* src/window.c (apply_window_adjustment): Remove redundant setting of
> 	windows_or_buffers_changed.
> 
>          ...
> 
> broke evaluating the following form with emacs -Q:
> 
> (set-window-scroll-bars nil 0 nil)
> 
> This should immediately remove the scroll bar of the selected window
> but instead hides its right fringe under the scroll bar.

Does the below look reasonable?  I'd like to apply it to the emacs-26
branch.

diff --git a/src/window.c b/src/window.c
index 5d99098..c93ab5c 100644
--- a/src/window.c
+++ b/src/window.c
@@ -7254,6 +7254,10 @@ set_window_scroll_bars (struct window *w, Lisp_Object width,
   wset_horizontal_scroll_bar_type (w, Qnil);
 #endif
 
+  /* This is needed to trigger immediate redisplay of the window when
+     scroll bars are changed.  */
+  if (changed)
+    windows_or_buffers_changed = 31;
   return changed ? w : NULL;
 }
 





  reply	other threads:[~2018-12-10  9:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-10  8:41 bug#33694: 27.0.50; 'set-window-scroll-bars' broken martin rudalics
2018-12-10  9:52 ` Eli Zaretskii [this message]
2018-12-10 17:44   ` martin rudalics
2018-12-10 18:09     ` Eli Zaretskii
2018-12-11  8:34       ` martin rudalics
2018-12-11  8:43         ` Eli Zaretskii
2018-12-11  9:05           ` martin rudalics
2018-12-11 10:33             ` Eli Zaretskii
2018-12-12  8:30               ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=835zw13dza.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=33694@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.