From: Eli Zaretskii <eliz@gnu.org>
To: Tobias Zawada <i_inbox@tn-home.de>
Cc: 34769@debbugs.gnu.org
Subject: bug#34769: Bug in emacs 26.1 gdb-send match-string applied after non-matching string-match
Date: Wed, 06 Mar 2019 20:18:07 +0200 [thread overview]
Message-ID: <835zsvdfz4.fsf@gnu.org> (raw)
In-Reply-To: <1969119607.262870.1551871623530@email.ionos.de> (message from Tobias Zawada on Wed, 6 Mar 2019 12:27:03 +0100 (CET))
> Date: Wed, 6 Mar 2019 12:27:03 +0100 (CET)
> From: Tobias Zawada <i_inbox@tn-home.de>
>
> At the end of gdb-send one finds the following lines:
>
> (let* ((control-command-p (string-match gdb-control-commands-regexp string))
> (command-arg (match-string 3 string))
>
> It is wrong to call (match-string 3 string) if (string-match gdb-control-commands-regexp string) returned nil.
> The doc of match-string says:
> "Return string of text matched by last search."
> That means match-string only returns sensible results if the last match was successful.
That is true, and a cleanup is a good idea. But please note that the
undefined results are not used if control-command-p is nil, so the
issue is not that serious.
Thanks.
next prev parent reply other threads:[~2019-03-06 18:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-06 11:27 bug#34769: Bug in emacs 26.1 gdb-send match-string applied after non-matching string-match Tobias Zawada
2019-03-06 18:18 ` Eli Zaretskii [this message]
2019-03-06 20:10 ` Tobias Zawada
2019-03-07 15:18 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=835zsvdfz4.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=34769@debbugs.gnu.org \
--cc=i_inbox@tn-home.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.