From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Fill column indicator functionality Date: Sat, 06 Apr 2019 09:49:49 +0300 Message-ID: <835zrrbpbm.fsf@gnu.org> References: <83sguzekc5.fsf@gnu.org> <20190403102234.gyk45tfk4uypilhn@Ergus> <83d0m3e43f.fsf@gnu.org> <20190405103614.oivi4mtlnklldli4@Ergus> <835zrsd670.fsf@gnu.org> <20190405150404.bm2d6wjtivwyesek@Ergus> <83r2agbhwv.fsf@gnu.org> <20190405173010.snavjhxrmmufwp54@Ergus> <83h8bcb7ce.fsf@gnu.org> <20190405200319.jfwt7lgevas556id@Ergus> <87zhp4w42x.fsf@telefonica.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="173311"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: =?utf-8?Q?=C3=93scar?= Fuentes Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Apr 06 08:50:09 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hCf9U-000iyh-9a for ged-emacs-devel@m.gmane.org; Sat, 06 Apr 2019 08:50:08 +0200 Original-Received: from localhost ([127.0.0.1]:51413 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hCf9T-0001M6-BS for ged-emacs-devel@m.gmane.org; Sat, 06 Apr 2019 02:50:07 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60674) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hCf9N-0001Lt-93 for emacs-devel@gnu.org; Sat, 06 Apr 2019 02:50:02 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37021) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hCf9M-0005fg-Jc; Sat, 06 Apr 2019 02:50:00 -0400 Original-Received: from [176.228.60.248] (port=1277 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hCf9M-0006it-1e; Sat, 06 Apr 2019 02:50:00 -0400 In-reply-to: <87zhp4w42x.fsf@telefonica.net> (message from =?utf-8?Q?=C3=93scar?= Fuentes on Fri, 05 Apr 2019 23:10:46 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235020 Archived-At: > From: Óscar Fuentes > Date: Fri, 05 Apr 2019 23:10:46 +0200 > > I have a patch from some days ago applied here, sorry if this is > outdated, but I see something suspicious. After M-x customize-variable > display-fill-column-indicator-character : > > > Hide display-fill-column-indicator-character: nil > State : STANDARD. (mismatch) > Character to draw the indicator when ‘display-fill-column-indicator’ is non-n > > > That "nil" and "mismatch" are not right. This is the definition of the > variable in xdisp.c: > > > DEFVAR_LISP ("display-fill-column-indicator-character", Vdisplay_fill_column_indicator_character, > doc: /* Character to draw the indicator when `display-fill-column-indicator' is non-nil. > The default is U+2502 but a good alternative is (ascii 124) if > the font in fill-column-face does not support Unicode characters. */); > Vdisplay_fill_column_indicator_character = Qnil; > DEFSYM (Qdisplay_fill_column_indicator_character, "display-fill-column-indicator-character"); > Fmake_variable_buffer_local (Qdisplay_fill_column_indicator_character); Hmm... why do we need those DEFSYMs? I don't think the Qfoo symbols are ever used in C, are they? Do the problems go away if you remove the DEFSYMS?