From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCH] Add a new user option 'ido-big-directories'.
Date: Fri, 12 Apr 2019 15:58:56 +0300
Message-ID: <835zrjmlbj.fsf@gnu.org>
References: <20190412122301.98921-1-phst@google.com>
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="213895"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: phst@google.com, emacs-devel@gnu.org
To: Philipp Stephani <p.stephani2@gmail.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 12 15:00:49 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hEvnR-000tR1-3x
	for ged-emacs-devel@m.gmane.org; Fri, 12 Apr 2019 15:00:45 +0200
Original-Received: from localhost ([127.0.0.1]:36204 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hEvnO-0000cb-HJ
	for ged-emacs-devel@m.gmane.org; Fri, 12 Apr 2019 09:00:42 -0400
Original-Received: from eggs.gnu.org ([209.51.188.92]:48216)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1hEvm1-0000Px-Kx
	for emacs-devel@gnu.org; Fri, 12 Apr 2019 08:59:19 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59785)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
	id 1hEvm0-0000uh-Qy; Fri, 12 Apr 2019 08:59:17 -0400
Original-Received: from [176.228.60.248] (port=3798 helo=home-c4e4a596f7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.82) (envelope-from <eliz@gnu.org>)
	id 1hEvlx-0007Fl-Li; Fri, 12 Apr 2019 08:59:14 -0400
In-reply-to: <20190412122301.98921-1-phst@google.com> (message from Philipp
	Stephani on Fri, 12 Apr 2019 14:23:01 +0200)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel/>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:235339
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/235339>

> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Fri, 12 Apr 2019 14:23:01 +0200
> Cc: Philipp Stephani <phst@google.com>
> 
> This provides an alternative to 'ido-max-directory-size', for
> directories that are statically known to be too big for Ido
> completion.

Thanks.

> +** Ido
> +*** New user option 'ido-big-directories' to mark certain directory
> +patterns as big.

This doesn't say what is a "pattern" and what is the meaning of "big"
in this context.  Could that be at least hinted at?

> +(defcustom ido-big-directories nil
> +  "Additional directories that should be considered big.
> +Ido will ignore directories matching any of these regular
> +expressions."

The doc string should explicitly say what is the form of the value.
Also, since the elements of the sequence are regular expressions, the
first sentence should mention that, or at least say they are strings.