From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#35602: 26.1; emacsclient doesn't go to the desired line Date: Tue, 07 May 2019 17:21:35 +0300 Message-ID: <835zqmjqfk.fsf@gnu.org> References: Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="124812"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35602@debbugs.gnu.org To: Robert Parlett Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 07 16:22:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hO0yx-000WIY-7S for geb-bug-gnu-emacs@m.gmane.org; Tue, 07 May 2019 16:22:11 +0200 Original-Received: from localhost ([127.0.0.1]:47637 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hO0yw-00074w-5b for geb-bug-gnu-emacs@m.gmane.org; Tue, 07 May 2019 10:22:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45747) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hO0yo-000749-UD for bug-gnu-emacs@gnu.org; Tue, 07 May 2019 10:22:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hO0yo-0002IO-1a for bug-gnu-emacs@gnu.org; Tue, 07 May 2019 10:22:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45745) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hO0yn-0002IF-TN for bug-gnu-emacs@gnu.org; Tue, 07 May 2019 10:22:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hO0yn-0000hd-O8 for bug-gnu-emacs@gnu.org; Tue, 07 May 2019 10:22:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 May 2019 14:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35602 X-GNU-PR-Package: emacs Original-Received: via spool by 35602-submit@debbugs.gnu.org id=B35602.15572389182691 (code B ref 35602); Tue, 07 May 2019 14:22:01 +0000 Original-Received: (at 35602) by debbugs.gnu.org; 7 May 2019 14:21:58 +0000 Original-Received: from localhost ([127.0.0.1]:59289 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hO0yj-0000hL-Hb for submit@debbugs.gnu.org; Tue, 07 May 2019 10:21:57 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59552) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hO0yh-0000h6-Ju for 35602@debbugs.gnu.org; Tue, 07 May 2019 10:21:56 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:60281) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hO0yc-00028x-Ay; Tue, 07 May 2019 10:21:50 -0400 Original-Received: from [176.228.60.248] (port=3710 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hO0yb-0001Ws-OX; Tue, 07 May 2019 10:21:50 -0400 In-reply-to: (message from Robert Parlett on Mon, 6 May 2019 11:05:19 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158874 Archived-At: > From: Robert Parlett > Date: Mon, 6 May 2019 11:05:19 +0100 > > 1 Start emacs with emacs -Q > 2 In emacs, start the server with M-x server-start > 3 In a shell, create some test text files :- > $ man bash >f1.txt > $ man top >f2.txt > 4 Now run the following commands in the shell :- > $ emacsclient +200 -n f1.txt > $ emacsclient +300 -n f2.txt > $ emacsclient +400 -n f1.txt > > The bug can be seen after the last emacsclient command above. The correct result would be that file f1.txt is > made the current buffer, with the cursor on line 400. However, instead it is made the current buffer with the > cursor remaining on line 200. Thanks for reporting this. This is switch-to-buffer-preserve-window-point in action. Does the patch below fix the problem for you? --- lisp/server.el~0 2019-01-16 06:33:00.000000000 +0200 +++ lisp/server.el 2019-05-07 17:20:14.108225200 +0300 @@ -1655,7 +1655,14 @@ (frame-terminal)))) 'nomini 'visible (selected-window)))) (condition-case nil - (switch-to-buffer next-buffer) + ;; If the client specified a new buffer position, + ;; treat that as an explicit point-move command, and + ;; override switch-to-buffer-preserve-window-point. + (let ((switch-to-buffer-preserve-window-point + (if filepos + nil + switch-to-buffer-preserve-window-point))) + (switch-to-buffer next-buffer)) ;; After all the above, we might still have ended up with ;; a minibuffer/dedicated-window (if there's no other). (error (pop-to-buffer next-buffer)))))))