From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#35702: xref revert-buffer Date: Fri, 24 May 2019 15:25:08 +0300 Message-ID: <835zq059az.fsf@gnu.org> References: <87tvdzv4m2.fsf@mail.linkov.net> <838suw5jvh.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="130730"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35702@debbugs.gnu.org, juri@linkov.net To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri May 24 14:28:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hU9Iw-000XrM-Kn for geb-bug-gnu-emacs@m.gmane.org; Fri, 24 May 2019 14:28:10 +0200 Original-Received: from localhost ([127.0.0.1]:53838 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hU9Iv-00056F-Ef for geb-bug-gnu-emacs@m.gmane.org; Fri, 24 May 2019 08:28:09 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48656) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hU9Gw-0003YN-FS for bug-gnu-emacs@gnu.org; Fri, 24 May 2019 08:26:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hU9Gs-0003VU-Rf for bug-gnu-emacs@gnu.org; Fri, 24 May 2019 08:26:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60916) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hU9Gr-0003Tt-QL for bug-gnu-emacs@gnu.org; Fri, 24 May 2019 08:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hU9Gr-0000CV-Lp for bug-gnu-emacs@gnu.org; Fri, 24 May 2019 08:26:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 May 2019 12:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35702 X-GNU-PR-Package: emacs Original-Received: via spool by 35702-submit@debbugs.gnu.org id=B35702.1558700705663 (code B ref 35702); Fri, 24 May 2019 12:26:01 +0000 Original-Received: (at 35702) by debbugs.gnu.org; 24 May 2019 12:25:05 +0000 Original-Received: from localhost ([127.0.0.1]:46223 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hU9Fx-0000Ac-Bo for submit@debbugs.gnu.org; Fri, 24 May 2019 08:25:05 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33968) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hU9Fv-00009x-HV for 35702@debbugs.gnu.org; Fri, 24 May 2019 08:25:04 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37900) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hU9Fq-0002s0-3j; Fri, 24 May 2019 08:24:58 -0400 Original-Received: from [176.228.60.248] (port=1395 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hU9Fp-0007od-E8; Fri, 24 May 2019 08:24:57 -0400 In-reply-to: (message from Dmitry Gutov on Fri, 24 May 2019 13:09:50 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159708 Archived-At: > Cc: 35702@debbugs.gnu.org, juri@linkov.net > From: Dmitry Gutov > Date: Fri, 24 May 2019 13:09:50 +0300 > > On 24.05.2019 11:36, Eli Zaretskii wrote: > > > Thanks, but that changeset has a few problems: > > > > . the new command xref--revert-xref-buffer uses an internal name, > > Is that a problem by itself? We have other bindings that use internal > command names as well. That's a problem, yes. Commands shouldn't be internal functions, by their very definition. > > and has no doc string > > How about something like: > > Refresh the search results by repeating the search. Given that it doesn't, at least after M-., this sounds like not all the truth. Can it be more detailed? > > . neither NEWS nor the user manual document the 'g' key in XREF > > buffers > > I can add the NEWS entry. Please do, and thanks. > > . it looks like this new command is not useful after M-., because I > > get an error message when I try using it (perhaps this is because > > I didn't understand its use case due to lack of docs) > > It has been a deliberate choice to simplify the implementation. IME, you > don't ever want to refresh the list of definitions. Well, one situation where I'd like to refresh is when the TAGS file was updated. It could mean that more identifiers matching the search string are now known. > But for other search results (references, apropos, > project-find-regexp, dired-do-find-regexp) it's a lot more common. At the very least, this should be reflected in the doc string. > Commit 49a363c875 also brings in another difference between the > behaviors of xref-find-definitions and xref-find-references: the latter > now shows the xref buffer even when there is just one hit. This should arguable be in NEWS. > > Let me know if I can help in fixing any of the above. (I tried to > > figure out what this command does and how, but quickly got lost in a > > chain of indirections via undocumented internal functions and > > variables, sorry.) > > Do you have a better idea now? Only slightly so. The code still doesn't speak to me, but I guess there isn't much that can be done about that. Thanks.