From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master d68ed15: Implement and document XDG-style startup files under ~/.config. Date: Mon, 03 Jun 2019 05:32:43 +0300 Message-ID: <835zpnv1o4.fsf@gnu.org> References: <20190525172356.30070.65317@vcs0.savannah.gnu.org> <20190525172357.86D4F207F5@vcs0.savannah.gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="72353"; mail-complaints-to="usenet@blaine.gmane.org" Cc: esr@thyrsus.com, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 03 04:33:07 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hXcmX-000Icz-6h for ged-emacs-devel@m.gmane.org; Mon, 03 Jun 2019 04:33:05 +0200 Original-Received: from localhost ([127.0.0.1]:56587 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hXcmV-0003RV-9s for ged-emacs-devel@m.gmane.org; Sun, 02 Jun 2019 22:33:03 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43195) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hXcmM-0003RC-Mv for emacs-devel@gnu.org; Sun, 02 Jun 2019 22:32:57 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37427) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hXcmL-000748-Fj; Sun, 02 Jun 2019 22:32:53 -0400 Original-Received: from [176.228.60.248] (port=1325 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hXcmK-0003oI-Mo; Sun, 02 Jun 2019 22:32:53 -0400 In-reply-to: (message from Stefan Monnier on Sun, 26 May 2019 18:40:10 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237203 Archived-At: > From: Stefan Monnier > Date: Sun, 26 May 2019 18:40:10 -0400 > Cc: "Eric S. Raymond" > > > -;;; startup.el --- process Emacs shell arguments -*- lexical-binding: t -*- > > +;; startup.el --- process Emacs shell arguments -*- lexical-binding: t -*- > > This is an error, it should be 3 semi-colons. > > > +(defun find-init-path (fn) > > + "Look in ~/.config/FOO or ~/.FOO for the dotfile or dot directory FOO. > > +It is expected that the output will undergo ~ expansion. Implements the > > +XDG convention for dotfiles." > > + (let* ((xdg-path (concat "~" init-file-user "/.config/" fn)) > > + (oldstyle-path (concat "~" init-file-user "/." fn)) > > + (found-path (if (file-exists-p xdg-path) xdg-path oldstyle-path))) > > + found-path)) > > AFAICT this is only used during startup and hence shouldn't have such > an "official sounding" name. It could/should use a "startup--" prefix, > for example. > > Furthermore it shouldn't say "path" but "filename" to follow our > naming convention. No response in a week. Would someone like to suggest changes to fix the problems in this commit? If so, please show the proposed changes, and let's discuss them. Failing that, I will revert that commit in a couple of days.