From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#36166: 27.0.50; Crash visiting HELLO when fringe-mode is disabled Date: Tue, 11 Jun 2019 18:53:52 +0300 Message-ID: <835zpc9kz3.fsf@gnu.org> References: <83ftog9ozy.fsf@gnu.org> <838su89nh1.fsf@gnu.org> <837e9s9m8o.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="168038"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36166@debbugs.gnu.org To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 11 18:29:42 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hajeY-000hbU-8A for geb-bug-gnu-emacs@m.gmane.org; Tue, 11 Jun 2019 18:29:42 +0200 Original-Received: from localhost ([::1]:60836 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hajeX-0007Yg-45 for geb-bug-gnu-emacs@m.gmane.org; Tue, 11 Jun 2019 12:29:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38025) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1haj79-00075L-Mq for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2019 11:55:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1haj75-0004vt-Su for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2019 11:55:09 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46499) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1haj6z-0004r3-RN for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2019 11:55:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1haj6z-0008NF-ND for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2019 11:55:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Jun 2019 15:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36166 X-GNU-PR-Package: emacs Original-Received: via spool by 36166-submit@debbugs.gnu.org id=B36166.156026844332113 (code B ref 36166); Tue, 11 Jun 2019 15:55:01 +0000 Original-Received: (at 36166) by debbugs.gnu.org; 11 Jun 2019 15:54:03 +0000 Original-Received: from localhost ([127.0.0.1]:60043 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1haj62-0008Ls-Mj for submit@debbugs.gnu.org; Tue, 11 Jun 2019 11:54:02 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57278) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1haj60-0008LN-U5 for 36166@debbugs.gnu.org; Tue, 11 Jun 2019 11:54:01 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:48623) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1haj5u-0003u1-31; Tue, 11 Jun 2019 11:53:55 -0400 Original-Received: from [176.228.60.248] (port=4403 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1haj5t-0008OK-Ds; Tue, 11 Jun 2019 11:53:53 -0400 In-reply-to: (message from Robert Pluim on Tue, 11 Jun 2019 17:32:50 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160384 Archived-At: > From: Robert Pluim > Cc: 36166@debbugs.gnu.org > Date: Tue, 11 Jun 2019 17:32:50 +0200 > > Eli> I think the important part is the test of s->font_not_found_p. Can > Eli> you see whether it's zero in the crash case? > >> > >> Yes, itʼs 0. > > Eli> Thanks. So I think this: > > Eli> if (EQ (font->driver->type, Qns)) > > Eli> should be amended like this: > > Eli> if (!s->font_not_found_p && EQ (font->driver->type, Qns)) > > Are you sure? if font_not_found_p == 0, then this condition will be > true, and font == NULL here, so we get a crash. Sorry, I've misinterpreted your finding. It actually means that the font_not_found_p flag is not working in this case. So now I _really_ want to hear Alan's opinion on this.