From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#36190: 27.0.50; `put-text-property' etc. with buffer argument calls current buffer's `after-change-functions' Date: Thu, 13 Jun 2019 22:05:48 +0300 Message-ID: <835zp9z4oj.fsf@gnu.org> References: <83h88tzbly.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="172352"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36190@debbugs.gnu.org To: Pip Cet Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 13 21:15:00 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hbVBb-000iew-Pe for geb-bug-gnu-emacs@m.gmane.org; Thu, 13 Jun 2019 21:14:59 +0200 Original-Received: from localhost ([::1]:44528 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbVBa-0000dV-PP for geb-bug-gnu-emacs@m.gmane.org; Thu, 13 Jun 2019 15:14:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42715) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbV3x-0001hh-Qj for bug-gnu-emacs@gnu.org; Thu, 13 Jun 2019 15:07:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hbV3w-0002An-Sj for bug-gnu-emacs@gnu.org; Thu, 13 Jun 2019 15:07:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50823) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hbV3u-00029e-Im for bug-gnu-emacs@gnu.org; Thu, 13 Jun 2019 15:07:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hbV3u-0004jm-Bm for bug-gnu-emacs@gnu.org; Thu, 13 Jun 2019 15:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Jun 2019 19:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36190 X-GNU-PR-Package: emacs Original-Received: via spool by 36190-submit@debbugs.gnu.org id=B36190.156045278218140 (code B ref 36190); Thu, 13 Jun 2019 19:07:02 +0000 Original-Received: (at 36190) by debbugs.gnu.org; 13 Jun 2019 19:06:22 +0000 Original-Received: from localhost ([127.0.0.1]:36130 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hbV3G-0004iV-BW for submit@debbugs.gnu.org; Thu, 13 Jun 2019 15:06:22 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33621) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hbV3D-0004iE-9s for 36190@debbugs.gnu.org; Thu, 13 Jun 2019 15:06:21 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:38653) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hbV33-0001a8-T3; Thu, 13 Jun 2019 15:06:12 -0400 Original-Received: from [176.228.60.248] (port=1902 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hbV2q-0003io-JJ; Thu, 13 Jun 2019 15:05:59 -0400 In-reply-to: (message from Pip Cet on Thu, 13 Jun 2019 18:48:23 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160516 Archived-At: > From: Pip Cet > Date: Thu, 13 Jun 2019 18:48:23 +0000 > Cc: 36190@debbugs.gnu.org > > > > As far as I can tell, this makes `put-text-property' with a buffer > > > argument pretty useless. > > > > Only if you have a buffer-local value of after-change-functions. > > I'm not sure what you're saying. I'm saying that the buffer argument to put-text-property is pretty useless only if you consider after-change-functions. The primary purpose of put-text-property is to modify text properties, not to call after-change-functions. For that primary purpose, the buffer argument is not useless. > That seems pretty wrong to me. In which cases do you think we're > seeing the right behavior? Where did I say that this behavior was right? > Here's a first patch, which adds a "buffer" argument to > signal_after_change, to be explicit about where the change happens. It > should be pretty cheap in the case where we don't switch buffers. Not sure I have a clear idea of how you intend to use that additional argument. Are you suggesting that we switch to that buffer? If so, how is that different from not using the buffer argument at all, and instead wrapping the call to put-text-property with with-current-buffer? Also, passing current_buffer sounds redundant to me anyway, because in that case signal_after_change will not need to do anything that it doesn't already do. I would pass NULL instead. Thanks.