all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Noam Postavsky <npostavs@gmail.com>
Cc: hendrik@askra.de, 13400@debbugs.gnu.org, monnier@iro.umontreal.ca
Subject: bug#13400: 23.4; overlapping process filter calls
Date: Sat, 27 Jul 2019 11:24:25 +0300	[thread overview]
Message-ID: <835znnnavb.fsf@gnu.org> (raw)
In-Reply-To: <87o91guoxl.fsf@gmail.com> (message from Noam Postavsky on Fri, 26 Jul 2019 23:38:46 -0400)

> From: Noam Postavsky <npostavs@gmail.com>
> Date: Fri, 26 Jul 2019 23:38:46 -0400
> Cc: 13400@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>
> 
> > - Section "37.9 Receiving Output from Processes" does not list
> >   process-send-string. How about other blocking I/O functions?
> 
> In the attached patch, I've added a mention/xref for functions which send
> data to processes.
> 
> > - Same in "37.9.2. Process Filter Functions"
> 
> This section is repeated twice (I addressed the second instance below).
> 
> > - Same in "37.4 Creating an Asynchronous Process" ,
> >   process-send-string is neither waiting for input not time
> >   delay.
> 
> I don't see any mention of process-send-string in that section, nor how
> it's relevant to the rest of this report.
> 
> > - "37.7 Sending Input to Processes" says that filters can run
> >   inside process-send-string, but it could be clearer about the
> >   point that this can also happen inside the same filter for the
> >   same process.
> 
> I'm not really convinced that is necessary.
> 
> > - "37.9.2 Process Filter Functions" ignores the problem
> >   completely. There should be a paragraph clearly stating this
> >   problem. Further, it would be nice, if the filter function
> >   example could be extended to correctly deal with this problem.
> 
> I added a mention of the possibility of recursion.  I'm not sure about
> making an example (specifically, what is the best way to deal with this
> problem?).

I agree with Noam's decisions, and think that his patch is fine.

Thanks.





  reply	other threads:[~2019-07-27  8:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-10 10:11 bug#13400: 23.4; overlapping process filter calls Hendrik Tews
2019-07-27  3:38 ` Noam Postavsky
2019-07-27  8:24   ` Eli Zaretskii [this message]
2019-08-04  0:02     ` Noam Postavsky
2019-08-04 16:29       ` Eli Zaretskii
2019-08-05 18:31       ` Stefan Monnier
2019-08-08  3:37         ` Noam Postavsky
2019-08-08 13:36           ` Eli Zaretskii
2019-08-09 21:36             ` Stefan Monnier
2019-08-10  1:39               ` Noam Postavsky
2019-08-10  9:03                 ` Stefan Monnier
2019-08-05 22:37   ` Hendrik Tews
2019-08-06  7:40     ` Stefan Monnier
2019-08-08  1:15     ` Noam Postavsky
2019-08-20 12:19       ` Noam Postavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=835znnnavb.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=13400@debbugs.gnu.org \
    --cc=hendrik@askra.de \
    --cc=monnier@iro.umontreal.ca \
    --cc=npostavs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.