From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [Emacs-diffs] master 6cd5678: Clarify compiler-pacifier in frame.c
Date: Mon, 26 Aug 2019 22:33:41 +0300
Message-ID: <835zmjg1re.fsf@gnu.org>
References: <835zmnjdjm.fsf@gnu.org>
 <227db16b-17d1-b44b-97b3-e80211415eef@cs.ucla.edu>
 <831rx9iupo.fsf@gnu.org>
 <32f9db09-0c04-df03-4bb7-76fe2aa9a88f@cs.ucla.edu>
 <83tva4fjkz.fsf@gnu.org>
 <87cb5a0c-bdd8-726c-80ed-92e9f3518a58@cs.ucla.edu>
 <83o90cfecf.fsf@gnu.org> <87lfvg3qbi.fsf@telefonica.net>
 <83imqjgb1g.fsf@gnu.org> <87ftln4wm0.fsf@telefonica.net>
 <83a7bvg4a2.fsf@gnu.org> <87blwb4u2i.fsf@telefonica.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="5853"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: emacs-devel@gnu.org
To: =?utf-8?Q?=C3=93scar?= Fuentes <ofv@wanadoo.es>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 26 21:36:05 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1i2Kmb-0001Nn-1L
	for ged-emacs-devel@m.gmane.org; Mon, 26 Aug 2019 21:36:05 +0200
Original-Received: from localhost ([::1]:57020 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1i2KmZ-0003if-EH
	for ged-emacs-devel@m.gmane.org; Mon, 26 Aug 2019 15:36:03 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41521)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>) id 1i2KkL-00026v-Am
 for emacs-devel@gnu.org; Mon, 26 Aug 2019 15:33:46 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45624)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
 id 1i2KkK-0006SF-Sc; Mon, 26 Aug 2019 15:33:44 -0400
Original-Received: from [176.228.60.248] (port=3939 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1i2KkH-0000T0-Jt; Mon, 26 Aug 2019 15:33:43 -0400
In-reply-to: <87blwb4u2i.fsf@telefonica.net> (message from
 =?utf-8?Q?=C3=93scar?= Fuentes on Mon, 26 Aug 2019 21:15:17 +0200)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:239588
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/239588>

> From: Óscar Fuentes <ofv@wanadoo.es>
> Date: Mon, 26 Aug 2019 21:15:17 +0200
> 
> > The initialization in this case was added because GCC flagged a
> > potential use-before-define.  After that, there's no more bug for
> > Valgrind to find, so I see no reason to leave UNINIT around.
> 
> Let's suppose that the warning was correct and the hacker was wrong when
> judged it bogus.

The warning was correct, and I didn't decide it was bogus.  I added
the initialization because the warning was NOT bogus.  Please see the
code and the comment.