From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: change pcomplete/make to include targets in included files
Date: Sat, 14 Sep 2019 13:57:10 +0300
Message-ID: <835zlvywl5.fsf@gnu.org>
References: <86muf7p5w7.fsf@stephe-leake.org> <837e6byyuc.fsf@gnu.org>
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="41433"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: emacs-devel@gnu.org
To: stephen_leake@stephe-leake.org
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Sep 14 12:57:29 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1i95k7-000AfN-0V
	for ged-emacs-devel@m.gmane.org; Sat, 14 Sep 2019 12:57:27 +0200
Original-Received: from localhost ([::1]:49282 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1i95k5-0002zb-PA
	for ged-emacs-devel@m.gmane.org; Sat, 14 Sep 2019 06:57:25 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50043)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>) id 1i95jb-0002zT-RI
 for emacs-devel@gnu.org; Sat, 14 Sep 2019 06:56:56 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49963)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
 id 1i95jb-0006zs-1U; Sat, 14 Sep 2019 06:56:55 -0400
Original-Received: from [176.228.60.248] (port=4297 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1i95ja-0000Lb-Cg; Sat, 14 Sep 2019 06:56:54 -0400
In-reply-to: <837e6byyuc.fsf@gnu.org> (message from Eli Zaretskii on Sat, 14
 Sep 2019 13:08:27 +0300)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:240029
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/240029>

> Date: Sat, 14 Sep 2019 13:08:27 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: emacs-devel@gnu.org
> 
> I have a couple of minor comments below, and I hope Stefan and others
> will provide more substantial ones, if they have them.

And one more:

> +(defcustom pcmpl-gnu-makefile-includes t
> +  "If non-nil, `pcomplete/make' includes targets in included files."
> +  :type 'boolean
> +  :group 'pcmpl-gnu)

When you add or change a defcustom, please always add/update its
:version tag.