bug#37240: [PATCH] Provide facility to ignore all marked files

bug#37240: [PATCH] Provide facility to ignore all marked files

[Wolfgang Scherer]

[-- Attachment #1: Type: text/plain, Size: 38 bytes --]

Feature request vor *vc-dir* buffer.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Provide-facility-to-ignore-all-marked-files.patch --]
[-- Type: text/x-patch; name="0001-Provide-facility-to-ignore-all-marked-files.patch", Size: 1224 bytes --]

From 7e2fd7641a15a11eca50af490c51927c170a7bb0 Mon Sep 17 00:00:00 2001
From: Wolfgang Scherer <wolfgang.scherer@gmx.de>
Date: Sat, 31 Aug 2019 00:01:40 +0200
Subject: [PATCH] Provide facility to ignore all marked files

* lisp/vc/vc-dir.el: (vc-dir-ignore) With prefix argument, ignore all
marked files.
---
 lisp/vc/vc-dir.el | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/lisp/vc/vc-dir.el b/lisp/vc/vc-dir.el
index 9a6f6bb..e225978 100644
--- a/lisp/vc/vc-dir.el
+++ b/lisp/vc/vc-dir.el
@@ -864,10 +864,18 @@ with the command \\[tags-loop-continue]."
    delimited)
   (fileloop-continue))

-(defun vc-dir-ignore ()
-  "Ignore the current file."
-  (interactive)
-  (vc-ignore (vc-dir-current-file)))
+(defun vc-dir-ignore (&optional arg)
+  "Ignore the current file.
+If a prefix argument is given, ignore all marked files."
+  (interactive "P")
+  (if arg
+      (ewoc-map
+       (lambda (filearg)
+	 (when (vc-dir-fileinfo->marked filearg)
+	   (vc-ignore (vc-dir-fileinfo->name filearg))
+	   t))
+       vc-ewoc)
+    (vc-ignore (vc-dir-current-file))))

 (defun vc-dir-current-file ()
   (let ((node (ewoc-locate vc-ewoc)))
--
2.7.4

bug#37240: [PATCH] Provide facility to ignore all marked files

[Eli Zaretskii]

> From: Wolfgang Scherer <Wolfgang.Scherer@gmx.de>
> Date: Sat, 31 Aug 2019 00:07:17 +0200
> 
> * lisp/vc/vc-dir.el: (vc-dir-ignore) With prefix argument, ignore all
> marked files.

Thanks.  User-visible changes should come with a suitable NEWS entry.

bug#37240: [PATCH] Provide facility to ignore all marked files

[Lars Ingebrigtsen]

Wolfgang Scherer <Wolfgang.Scherer@gmx.de> writes:

> Feature request vor *vc-dir* buffer.

Looks good; I've applied it to Emacs 27 with a NEWS entry.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#37240: [PATCH] Provide facility to ignore all marked files

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Sun, 15 Sep 2019 15:00:39 +0200
> Cc: 37240@debbugs.gnu.org
> 
> Wolfgang Scherer <Wolfgang.Scherer@gmx.de> writes:
> 
> > Feature request vor *vc-dir* buffer.
> 
> Looks good; I've applied it to Emacs 27 with a NEWS entry.

Should this command be mentioned in the "VC Directory Commands" node
of the user manual?

bug#37240: [PATCH] Provide facility to ignore all marked files

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

> Should this command be mentioned in the "VC Directory Commands" node
> of the user manual?

It wasn't previously, so my guess was that it wasn't considered
important enough to mention.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#37240: [PATCH] Provide facility to ignore all marked files

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: Wolfgang.Scherer@gmx.de,  37240@debbugs.gnu.org
> Date: Mon, 16 Sep 2019 14:35:41 +0200
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > Should this command be mentioned in the "VC Directory Commands" node
> > of the user manual?
> 
> It wasn't previously, so my guess was that it wasn't considered
> important enough to mention.

I think it wasn't mention by omission.

bug#37240: [PATCH] Provide facility to ignore all marked files

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

>> > Should this command be mentioned in the "VC Directory Commands" node
>> > of the user manual?
>> 
>> It wasn't previously, so my guess was that it wasn't considered
>> important enough to mention.
>
> I think it wasn't mention by omission.

OK; I've now added an entry for it in the manual.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#37240: [PATCH] Provide facility to ignore all marked files

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: Wolfgang.Scherer@gmx.de,  37240@debbugs.gnu.org
> Date: Mon, 16 Sep 2019 22:02:47 +0200
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> > Should this command be mentioned in the "VC Directory Commands" node
> >> > of the user manual?
> >> 
> >> It wasn't previously, so my guess was that it wasn't considered
> >> important enough to mention.
> >
> > I think it wasn't mention by omission.
> 
> OK; I've now added an entry for it in the manual.

Thanks!