From: Eli Zaretskii <eliz@gnu.org>
To: Carlos Pita <carlosjosepita@gmail.com>
Cc: rpluim@gmail.com, 37689@debbugs.gnu.org
Subject: bug#37689: Fringe pixmaps, widgets, etc. look ridiculously tiny in hidpi screen
Date: Mon, 14 Oct 2019 11:33:02 +0300 [thread overview]
Message-ID: <835zkrk9q9.fsf@gnu.org> (raw)
In-Reply-To: <CAELgYhe0i4BHdCnFX1XY4NH6zS4hMLt2PwwJ9uB53eGM7u5Aqw@mail.gmail.com> (message from Carlos Pita on Sun, 13 Oct 2019 21:40:14 -0300)
> From: Carlos Pita <carlosjosepita@gmail.com>
> Date: Sun, 13 Oct 2019 21:40:14 -0300
> Cc: Robert Pluim <rpluim@gmail.com>, 37689@debbugs.gnu.org
>
> 1.a. Do the scaling as downstream as possible. The problem with this
> approach is that I will be fixing the problem only for one backend
> (for example, Cairo). Also, I would have to "hack" some assumptions
> done upstream (for example, to adjust x, y and scale of a rectangle
> that is assumed to be of a different geometry by the caller). The
> advantage of the approach is that not only fringe icons but any other
> image that is rendered by the lowest level routine will be properly
> scaled; but, that said, I noticed that in emacs 26.3 widgets are not
> using x_cr_draw_image.
>
> 1.b. Do the scaling upstream (for example, in get_fringe_bitmap_data
> as proposed above). One problem with this approach is that some
> backend could already be scaling output itself (for example, by using
> a toolkit that automatically scales according to the device
> resolution... do you know if this is the case for windows, for
> macos?). Also, it won't fix the widgets issue (anyway, as I said,
> neither the "downstream" approach will do it in 26.3).
Granted, I prefer the second approach. We should do as little code
duplication as possible.
I don't think individual backends do any scaling, but if some do, it
should be easy to disable the scaling in our code for those backends.
> 2. I'm clueless regarding were widgets (I mean checkboxes and things
> like that) are rendered. With Cairo backend enabled, x_cr_draw_image
> is never reached in 26.3, its only user is the fringe module, I've
> checked this in the debugger and by inspecting the code. Not sure
> about 27, since tweaking x_cr_draw_image did have a (weird) effect, as
> the screenshots in my previous post show.
I'm not sure I understand how this is related to the issue at hand.
Can you elaborate?
Also, what exactly do you mean by "rendered"? In Emacs, there are
generally 2 stages of displaying any "display element" (a character,
an image, etc.): first, a backend-independent step of loading the
display element, determining its metrics, and performing the display
layout calculations derived from that; and then backend-dependent step
of actually delivering the display element to the glass. Which one of
those did you have in mind?
Thanks.
next prev parent reply other threads:[~2019-10-14 8:33 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 6:28 bug#37689: Fringe pixmaps, widgets, etc. look ridiculously tiny in hidpi screen Carlos Pita
2019-10-10 8:12 ` Eli Zaretskii
2019-10-10 13:26 ` Robert Pluim
2019-10-10 13:37 ` Carlos Pita
2019-10-10 13:47 ` Robert Pluim
2019-10-10 13:36 ` Carlos Pita
2019-10-10 14:21 ` Robert Pluim
2019-10-10 14:33 ` Carlos Pita
2019-10-10 14:37 ` Carlos Pita
2019-10-10 15:06 ` Eli Zaretskii
2019-10-10 15:43 ` Carlos Pita
2019-10-10 15:05 ` Eli Zaretskii
2019-10-10 15:51 ` Carlos Pita
2019-10-10 16:01 ` Carlos Pita
2019-10-10 17:35 ` Eli Zaretskii
2019-10-10 17:39 ` Carlos Pita
2019-10-11 3:26 ` Carlos Pita
2019-10-11 3:48 ` Carlos Pita
2019-10-12 0:51 ` Carlos Pita
2019-10-12 7:28 ` Eli Zaretskii
2019-10-12 7:56 ` Carlos Pita
2019-10-12 8:26 ` Carlos Pita
2019-10-14 0:40 ` Carlos Pita
2019-10-14 8:33 ` Eli Zaretskii [this message]
2019-10-14 13:19 ` Alan Third
2019-10-14 14:00 ` Eli Zaretskii
2019-10-17 11:48 ` Alan Third
2019-10-14 14:37 ` Carlos Pita
2019-10-14 14:54 ` Eli Zaretskii
2019-10-14 15:06 ` Carlos Pita
2019-10-14 15:15 ` Eli Zaretskii
2019-10-14 15:32 ` Carlos Pita
2019-10-14 16:52 ` Eli Zaretskii
2019-10-14 19:59 ` Carlos Pita
2019-10-14 23:42 ` Carlos Pita
2019-10-14 23:49 ` Carlos Pita
2019-10-15 1:50 ` Carlos Pita
2019-10-15 9:30 ` Eli Zaretskii
2019-10-15 23:01 ` Carlos Pita
2019-10-16 4:25 ` Carlos Pita
2019-10-16 9:16 ` martin rudalics
2019-10-16 16:31 ` Carlos Pita
2019-10-16 16:40 ` Carlos Pita
2019-10-16 19:01 ` Carlos Pita
2019-10-17 8:13 ` Robert Pluim
2019-10-15 9:27 ` Eli Zaretskii
2019-10-20 16:03 ` Juri Linkov
2019-10-20 17:37 ` Carlos Pita
2019-10-20 18:52 ` Juri Linkov
2019-10-20 19:17 ` Carlos Pita
2019-10-24 17:09 ` Carlos Pita
2019-10-26 10:45 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=835zkrk9q9.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=37689@debbugs.gnu.org \
--cc=carlosjosepita@gmail.com \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.