From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>, Kenichi Handa <handa@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Auto de-composition when point is inside a composition
Date: Mon, 21 Oct 2019 19:07:02 +0300 [thread overview]
Message-ID: <835zki2ic9.fsf@gnu.org> (raw)
In-Reply-To: <jwvd0eqp536.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Mon, 21 Oct 2019 10:15:43 -0400)
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Mon, 21 Oct 2019 10:15:43 -0400
>
> I was recently looking at the following code in keyboard.c:
>
> if (last_point_position > BEGV
> && last_point_position < ZV
> && (composition_adjust_point (last_point_position,
> last_point_position)
> != last_point_position))
> /* The last point was temporarily set within a grapheme
> cluster to prevent automatic composition. To recover
> the automatic composition, we must update the
> display. */
> windows_or_buffers_changed = 21;
>
> and wondered:
>
> - why do we need to set windows_or_buffers_changed at all here?
> after all, this code is only run in some circumstances, definitely not
> all the circumstances where we might need to redraw the grapheme
> cluster after point moved out of it, so it seems it's not the right
> place to handle this case (it seems either redundant or insufficient).
Maybe because otherwise the redisplay optimizations taken in case only
point moved could fail to redisplay (they might only redraw the
character at point, and fail to include the rest of the composition)?
> - more importantly, does the inhibition of composition when point is in
> the middle of it still work? I don't use languages which rely on
> composition so I'm not completely sure how this feature is/was
> supposed to work, but I do remember searching for "lam" in Elisp
> buffers in which I had "lambda" prettified to "λ" and having those "λ"
> temporarily be expanded back to "lambda" to show the cursor in the
> middle of it. Yet, I can't seem to reproduce this de-composition
> behavior any more. Is it still working? How can I trigger it?
Could be related to Backspace deleting just part of the grapheme
cluster? Or searching for a codepoint that is part of a composition?
But that's guessing, I don't really know the answer to this. Perhaps
Handa-san (CC'ed) does.
next prev parent reply other threads:[~2019-10-21 16:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 14:15 Auto de-composition when point is inside a composition Stefan Monnier
2019-10-21 16:07 ` Eli Zaretskii [this message]
2019-10-21 18:43 ` Stefan Monnier
2019-10-21 19:08 ` Stefan Monnier
2019-10-22 14:52 ` Eli Zaretskii
2019-10-22 14:54 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=835zki2ic9.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=handa@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.