From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#38013: [PATCH] Rectangular region selection with mouse Date: Sat, 23 Nov 2019 13:57:24 +0200 Message-ID: <835zjavm8r.fsf@gnu.org> References: <83lft0m3ug.fsf@gnu.org> <3541E0E8-9E33-4FBD-B0D9-DFF77C241F6F@acm.org> <83y2wzlorw.fsf@gnu.org> <83v9s3lo5f.fsf@gnu.org> <75EC4FBC-F636-4D75-BAC4-982D85188794@acm.org> <9b9222ad-ead7-d0a0-0602-780d0680f070@gmx.at> <6bf229f4-c22f-c3c2-5158-5235f908de3c@gmx.at> <8ec84837-172c-1ce5-cab0-b4c96a86274e@gmx.at> <411EAB4E-B666-4263-8514-5F47391268B1@acm.org> <2df02c1f-fea4-f764-eba6-fd67de581755@gmx.at> <3b74a108-28e3-fd01-64a5-7c4302e3d979@gmx.at> <9A9D13F2-1F4F-4DD4-B92F-96FC4D91DFBD@acm.org> <83pni17x5b.fsf@gnu.org> <8B95D2D3-8E00-45BF-B57D-EFD49D79EB6A@acm.org> <83bltk95p7.fsf@gnu.org> <60DD9D65-C3F0-470E-8489-B333E1889D32@acm.org> <83ftio6lsy.fsf@gnu.org> <290E5E66-964B-4E29-B141-166447AD5556@acm.org> <175E5B2E-2256-4FCD-AA8E-9E5BC6DE7907@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="34390"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 38013@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 23 12:58:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iYU3H-0008pr-B8 for geb-bug-gnu-emacs@m.gmane.org; Sat, 23 Nov 2019 12:58:11 +0100 Original-Received: from localhost ([::1]:58296 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iYU3G-0006e5-94 for geb-bug-gnu-emacs@m.gmane.org; Sat, 23 Nov 2019 06:58:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33343) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iYU3A-0006dx-IC for bug-gnu-emacs@gnu.org; Sat, 23 Nov 2019 06:58:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iYU39-0002Ab-Jg for bug-gnu-emacs@gnu.org; Sat, 23 Nov 2019 06:58:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47036) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iYU39-0002A8-FV for bug-gnu-emacs@gnu.org; Sat, 23 Nov 2019 06:58:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iYU39-0002vV-Bi for bug-gnu-emacs@gnu.org; Sat, 23 Nov 2019 06:58:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Nov 2019 11:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38013 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 38013-submit@debbugs.gnu.org id=B38013.157451026111222 (code B ref 38013); Sat, 23 Nov 2019 11:58:01 +0000 Original-Received: (at 38013) by debbugs.gnu.org; 23 Nov 2019 11:57:41 +0000 Original-Received: from localhost ([127.0.0.1]:55857 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYU2l-0002uu-7N for submit@debbugs.gnu.org; Sat, 23 Nov 2019 06:57:39 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:52472) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYU2g-0002ua-S0 for 38013@debbugs.gnu.org; Sat, 23 Nov 2019 06:57:35 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:58226) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iYU2b-0001i8-4E; Sat, 23 Nov 2019 06:57:29 -0500 Original-Received: from [176.228.60.248] (port=3378 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iYU2a-0007Ue-BD; Sat, 23 Nov 2019 06:57:28 -0500 In-reply-to: <175E5B2E-2256-4FCD-AA8E-9E5BC6DE7907@acm.org> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Mon, 18 Nov 2019 19:08:24 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172279 Archived-At: > From: Mattias Engdegård > Date: Mon, 18 Nov 2019 19:08:24 +0100 > Cc: rudalics@gmx.at, 38013@debbugs.gnu.org > > Here is an updated patch that makes the selection work better with characters that aren't a multiple of the standard font width. Thanks, a few minor comments: > +@defvar fine-grained-mouse-movement I think this variable's name should start with "mouse-". Like mouse-fine-grained-movement or something. > + (setq fine-grained-mouse-movement t) What happens if this function signals an error? won't fine-grained-mouse-movement be left at its non-nil value?