From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37527: [PATCH] Install C source code for for debugging help Date: Sat, 25 Jan 2020 09:58:42 +0200 Message-ID: <835zh0q85p.fsf@gnu.org> References: <20190926200752.12563-1-eggert@cs.ucla.edu> <89682bf5-de07-b114-90d1-cff9e4d62e5f@cs.ucla.edu> <83tv8yjjaz.fsf@gnu.org> <877e5uglp8.fsf@gmx.de> <83lfuaj7ix.fsf@gnu.org> <878sq9a4tm.fsf@gmx.de> <83lfu9hscn.fsf@gnu.org> <87y2y8944m.fsf@gmx.de> <837e5siwmz.fsf@gnu.org> <87pnje6jaf.fsf@gmx.de> <87imp46f5n.fsf@gmx.de> <3c936479-9341-caf1-2d08-7c236a660061@cs.ucla.edu> <87lftwbn4t.fsf@gmx.de> <733562c8-8676-4c73-34ff-a3f6659e5b70@cs.ucla.edu> <838spvznjz.fsf@gnu.org> <875zkzpnpf.fsf@gmx.de> <83ftk3xxd2.fsf@gnu.org> <87lfq2rlh0.fsf@marxist.se> <89b5298c-bc22-06ae-635a-0bf6b9dccb56@cs.ucla.edu> <8336c8wxmn.fsf@gnu.org> <83sgk8vg6y.fsf@gnu.org> <0f25beb7-19f6-cd78-e355-bc9af1f8384d@cs.ucla.edu> <83h80oupya.fsf@gnu.org> <83k15itfoa.fsf@gnu.org> <162efbd0-5d99-4074-4a4c-e186b0765f70@cs.ucla.edu> <83y2tyrpxx.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="51055"; mail-complaints-to="usenet@ciao.gmane.io" Cc: stefan@marxist.se, michael.albinus@gmx.de, 37527@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 25 09:00:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ivGMW-000DFD-HO for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Jan 2020 09:00:12 +0100 Original-Received: from localhost ([::1]:51692 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ivGMV-0006F8-F3 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Jan 2020 03:00:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33345) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ivGMO-0006Ez-62 for bug-gnu-emacs@gnu.org; Sat, 25 Jan 2020 03:00:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ivGMN-0002bK-2w for bug-gnu-emacs@gnu.org; Sat, 25 Jan 2020 03:00:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48969) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ivGMM-0002aV-Vm for bug-gnu-emacs@gnu.org; Sat, 25 Jan 2020 03:00:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ivGMM-0005sR-Tt for bug-gnu-emacs@gnu.org; Sat, 25 Jan 2020 03:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Jan 2020 08:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37527 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37527-submit@debbugs.gnu.org id=B37527.157993914922486 (code B ref 37527); Sat, 25 Jan 2020 08:00:02 +0000 Original-Received: (at 37527) by debbugs.gnu.org; 25 Jan 2020 07:59:09 +0000 Original-Received: from localhost ([127.0.0.1]:54942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ivGLU-0005qc-Ir for submit@debbugs.gnu.org; Sat, 25 Jan 2020 02:59:08 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:52307) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ivGLT-0005qD-14 for 37527@debbugs.gnu.org; Sat, 25 Jan 2020 02:59:07 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:53554) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ivGLM-0001Z1-VN; Sat, 25 Jan 2020 02:59:01 -0500 Original-Received: from [176.228.60.248] (port=2287 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ivGLI-00037E-P4; Sat, 25 Jan 2020 02:58:57 -0500 In-reply-to: (message from Paul Eggert on Fri, 24 Jan 2020 16:47:49 -0800) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175254 Archived-At: > Cc: stefan@marxist.se, michael.albinus@gmx.de, rgm@gnu.org, > 37527-done@debbugs.gnu.org > From: Paul Eggert > Date: Fri, 24 Jan 2020 16:47:49 -0800 > > OK, I did it that way by installing the attached patch instead; the new > separate variable is 'emacs-source-directory'. Thanks, but the name of this variable gives no clue about the sources being installed as part of "make install", and neither does its documentation. How about emacs-installed-source-directory? > +DEBUGGING AN INSTALLED EMACS > + > +* Installed Emacs source code > + > +Emacs installs a compressed copy of much of its source code, to make "optionally installs", right? This is an opt-in feature, right? > @@ -374,6 +377,7 @@ epaths-force: > -e 's;\(#.*PATH_BITMAPS\).*$$;\1 "${bitmapdir}";' \ > -e 's;\(#.*PATH_X_DEFAULTS\).*$$;\1 "${x_default_search_path}";' \ > -e 's;\(#.*PATH_GAME\).*$$;\1 $(PATH_GAME);' \ > + -e 's;\(#.*PATH_EMACS_SOURCE\).*$$;\1 "${emacs_srcdir}";' \ > -e 's;\(#.*PATH_DOC\).*$$;\1 "${etcdocdir}";') && \ > ${srcdir}/build-aux/move-if-change epaths.h.$$$$ src/epaths.h The epath-force-w32 part needs a similar change. > +AC_ARG_ENABLE([install-srcdir], > + [AS_HELP_STRING([--disable-install-srcdir], > + [do not install low-level Emacs source code useful for debugging.])], I don't think we agreed to make this on by default, did we? > +** The new variable 'emacs-source-directory' gives the Emacs source > +code location. This should explain that this is a copy of the sources, different from the original source tree where Emacs was built. > (defvar find-function-C-source-directory > - (let ((dir (expand-file-name "src" source-directory))) > - (if (file-accessible-directory-p dir) dir)) > + (let ((dir (expand-file-name "src" emacs-source-directory))) > + (if (file-accessible-directory-p dir) dir > + (setq dir (expand-file-name "src" source-directory)) > + (if (file-accessible-directory-p dir) dir))) This is backwards, IMO: it should first try the original source tree, and only next the installed sources.