From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#39555: [PATCH] Allow tempo-define-template to reassign tags to new templates Date: Fri, 14 Feb 2020 12:12:03 +0200 Message-ID: <835zg9pjf0.fsf@gnu.org> References: <877e0u9in7.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="12854"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 39555@debbugs.gnu.org To: Federico Tedin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 14 11:13:18 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j2XyH-0003Gx-IF for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Feb 2020 11:13:17 +0100 Original-Received: from localhost ([::1]:36908 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j2XyG-0001Kg-Ke for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Feb 2020 05:13:16 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60854) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j2Xy3-0000zo-Aj for bug-gnu-emacs@gnu.org; Fri, 14 Feb 2020 05:13:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j2Xy2-00033c-Ey for bug-gnu-emacs@gnu.org; Fri, 14 Feb 2020 05:13:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54915) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j2Xy2-00033R-B9 for bug-gnu-emacs@gnu.org; Fri, 14 Feb 2020 05:13:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j2Xy2-00013o-6M for bug-gnu-emacs@gnu.org; Fri, 14 Feb 2020 05:13:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Feb 2020 10:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39555 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39555-submit@debbugs.gnu.org id=B39555.15816751294009 (code B ref 39555); Fri, 14 Feb 2020 10:13:02 +0000 Original-Received: (at 39555) by debbugs.gnu.org; 14 Feb 2020 10:12:09 +0000 Original-Received: from localhost ([127.0.0.1]:60888 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j2XxB-00012a-Bb for submit@debbugs.gnu.org; Fri, 14 Feb 2020 05:12:09 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45443) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j2Xx9-00012H-7o for 39555@debbugs.gnu.org; Fri, 14 Feb 2020 05:12:07 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:47208) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j2Xx2-0001C4-4r; Fri, 14 Feb 2020 05:12:02 -0500 Original-Received: from [176.228.60.248] (port=2912 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1j2Xx1-00006a-K9; Fri, 14 Feb 2020 05:11:59 -0500 In-reply-to: <877e0u9in7.fsf@gmail.com> (message from Federico Tedin on Mon, 10 Feb 2020 23:34:04 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176044 Archived-At: > From: Federico Tedin > Date: Mon, 10 Feb 2020 23:34:04 +0100 > > (This may apply as a bug and as a wishlist item at the same time - not sure) I think this should go to master in any case. Given that tempo.el is not actively maintained lately, I think you can install your changes, after taking care of the minor issues below. > -(defun tempo-invalidate-collection () > +(defun tempo-invalidate-collection (&optional global) > "Marks the tag collection as obsolete. > -Whenever it is needed again it will be rebuilt." > - (setq tempo-dirty-collection t)) > +Whenever it is needed again it will be rebuilt. When GLOBAL is ^^^^ Please use "if", not "when". That's our usual style of describing optional arguments. I think the API changes should be in NEWS. Thanks.