From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#40940: 27.0.91; project-query-replace-regexp stops too early Date: Sat, 02 May 2020 09:44:30 +0300 Message-ID: <835zdevnsh.fsf@gnu.org> References: <871ro7ptk0.fsf@runbox.com> <9ba1394f-5a29-8e8d-93cf-9b794b8ebb98@yandex.ru> <83d07q217v.fsf@gnu.org> <87ftcmhezl.fsf@runbox.com> <831ro61yce.fsf@gnu.org> <83zhauzlt7.fsf@gnu.org> <83mu6uzi8h.fsf@gnu.org> <32c0b31e-9165-faff-c9a0-9103d937898b@yandex.ru> <835zdgw3aj.fsf@gnu.org> <83sggjveto.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="87627"; mail-complaints-to="usenet@ciao.gmane.io" Cc: simenheg@runbox.com, monnier@IRO.UMontreal.CA, 40940@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 02 08:46:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jUluc-000MhY-8H for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 02 May 2020 08:46:10 +0200 Original-Received: from localhost ([::1]:53058 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUlub-0004ez-AQ for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 02 May 2020 02:46:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48044) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jUluU-0004ea-Ud for bug-gnu-emacs@gnu.org; Sat, 02 May 2020 02:46:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jUluU-0003t4-Ak for bug-gnu-emacs@gnu.org; Sat, 02 May 2020 02:46:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39573) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jUluT-0003sx-TY for bug-gnu-emacs@gnu.org; Sat, 02 May 2020 02:46:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jUluT-0007Gs-Qm for bug-gnu-emacs@gnu.org; Sat, 02 May 2020 02:46:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 May 2020 06:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40940 X-GNU-PR-Package: emacs Original-Received: via spool by 40940-submit@debbugs.gnu.org id=B40940.158840190727880 (code B ref 40940); Sat, 02 May 2020 06:46:01 +0000 Original-Received: (at 40940) by debbugs.gnu.org; 2 May 2020 06:45:07 +0000 Original-Received: from localhost ([127.0.0.1]:51119 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUltN-0007Eg-Pr for submit@debbugs.gnu.org; Sat, 02 May 2020 02:45:07 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44916) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUltG-0007EK-P6 for 40940@debbugs.gnu.org; Sat, 02 May 2020 02:44:52 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:51301) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUltB-0002mQ-4D; Sat, 02 May 2020 02:44:41 -0400 Original-Received: from [176.228.60.248] (port=4393 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jUltA-0004ls-8G; Sat, 02 May 2020 02:44:40 -0400 In-Reply-To: (message from Dmitry Gutov on Sat, 2 May 2020 02:21:57 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:179479 Archived-At: > Cc: simenheg@runbox.com, monnier@IRO.UMontreal.CA, 40940@debbugs.gnu.org > From: Dmitry Gutov > Date: Sat, 2 May 2020 02:21:57 +0300 > > >> Sorry if that was unclear: I think we'd need to update the docstring of > >> fileloop-initialize-replace. Which doesn't offer any hints that the > >> logic of isearch-no-upper-case-p will be employed. > > > > Ah, okay. Agreed. > > Should I leave that to you? At least the "updated docstring" part. I can update the doc string, yes. But I don't think it's a good idea to divide the coding part between us, though. So please show the code, and I will suggest the doc change. > >> Since we bind search-upper-case to nil in this patch, perform-replace > >> won't try to alter the value of case-fold-search internally. > > > > But that's contrary to how query-replace works, isn't it? > > I suppose. But query-replace documents that aspects of its behavior: > > Matching is independent of case if `case-fold-search' is non-nil and > FROM-STRING has no uppercase letters. Sure. Wouldn't users of project-query-replace-regexp expect the same? > Though it doesn't mention the search-upper-case variable. Ugh! That should be fixed, of course.