From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: mail@vasilij.de, 42998@debbugs.gnu.org
Subject: bug#42998: 27.1; gnutls-symmetric-encrypt slow when providing cipher as symbol
Date: Mon, 24 Aug 2020 16:31:44 +0300 [thread overview]
Message-ID: <835z986ugv.fsf@gnu.org> (raw)
In-Reply-To: <87y2m4ci5u.fsf@gnus.org> (message from Lars Ingebrigtsen on Mon, 24 Aug 2020 15:01:01 +0200)
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Mon, 24 Aug 2020 15:01:01 +0200
> Cc: 42998@debbugs.gnu.org
>
> Vasilij Schneidermann <mail@vasilij.de> writes:
>
> > I'd consider either to
> > document this behavior or making the mapping more efficient, for example
> > by caching the cipher list instead of recomputing it over and over
> > again.
>
> The following fixes the problem, but I'm not quite sure whether it's
> correct... Is initialising a Lisp_Object to NULL something that's
> allowed over all platforms?
Since Lisp_Object is not really a pointer, at least not in all builds,
this might work, but is fragile, and thus not recommended.
> I can't initialise it to the more natural Qnil, since that's not a
> constant, C-wise.
Such initializations shall be done in the syms_of_* functions, in this
case syms_of_gnutls -- those run at build time, and are recorded in
the dumped memory. yes, that means the static variable will not be
private to the function, but I don't think it's a problem. I think
it'd also allow you to staticpro the variable only once.
Thanks.
next prev parent reply other threads:[~2020-08-24 13:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-23 16:43 bug#42998: 27.1; gnutls-symmetric-encrypt slow when providing cipher as symbol Vasilij Schneidermann
2020-08-24 13:01 ` Lars Ingebrigtsen
2020-08-24 13:31 ` Eli Zaretskii [this message]
2020-08-24 14:22 ` Lars Ingebrigtsen
2020-08-24 14:33 ` Eli Zaretskii
2020-08-24 14:28 ` Lars Ingebrigtsen
2020-08-24 14:36 ` Eli Zaretskii
2020-08-24 14:45 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=835z986ugv.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=42998@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=mail@vasilij.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.