all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Ken Brown <kbrown@cornell.edu>
Cc: larsi@gnus.org, dmoncayo@gmail.com, 25542@debbugs.gnu.org,
	npostavs@users.sourceforge.net
Subject: bug#25542: 25.1; Restoring the frame from fullscreen to maximized
Date: Sat, 05 Sep 2020 19:07:53 +0300	[thread overview]
Message-ID: <835z8sp5pi.fsf@gnu.org> (raw)
In-Reply-To: <5bd82b3a-0108-5dd4-88dd-e3def6b77e01@cornell.edu> (message from Ken Brown on Sat, 5 Sep 2020 11:10:31 -0400)

> Cc: Lars Magne Ingebrigtsen <larsi@gnus.org>, 25542@debbugs.gnu.org,
>  Noam Postavsky <npostavs@users.sourceforge.net>,
>  martin rudalics <rudalics@gmx.at>
> From: Ken Brown <kbrown@cornell.edu>
> Date: Sat, 5 Sep 2020 11:10:31 -0400
> 
> diff --git a/src/w32term.c b/src/w32term.c
> index 76cf6bd696..c7da95528b 100644
> --- a/src/w32term.c
> +++ b/src/w32term.c
> @@ -5454,15 +5454,7 @@ w32_read_socket (struct terminal *terminal,
>                       simple hack to check that based on the fact that
>                       only a maximized fullscreen frame should have both
>                       top/left outside the screen.  */
> -                 if (EQ (fullscreen, Qfullwidth) || EQ (fullscreen, Qfullheight)
> -                     || NILP (fullscreen))
> -                     {
> -                       int x, y;
> -
> -                       w32_real_positions (f, &x, &y);
> -                       if (x < 0 && y < 0)
> -                         store_frame_param (f, Qfullscreen, Qmaximized);
> -                     }
> +                   store_frame_param (f, Qfullscreen, Qmaximized);
>                    }
> 
>                    break;
> 
> If I make this change and follow Dani's recipe from the original bug report, the 
> second F11 press doesn't restore the previous state.  Instead, the frame appears 
> to get slightly smaller for an instant and then immediately reverts to 
> fullscreen mode.

Thanks for testing.  It sounds like the proposed change leaves the
original incorrect behavior unchanged, so we need to look for some
different way of fixing this.





  reply	other threads:[~2020-09-05 16:07 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-26  8:15 bug#25542: 25.1; Restoring the frame from fullscreen to maximized Dani Moncayo
2017-01-26  9:51 ` martin rudalics
2017-01-26 10:20   ` Dani Moncayo
2017-01-26 10:54     ` Dani Moncayo
2017-01-26 17:49       ` Dani Moncayo
2017-01-26 18:02         ` Noam Postavsky
2017-01-26 19:06         ` martin rudalics
2017-01-27  7:54           ` Dani Moncayo
2017-01-27  9:18             ` martin rudalics
2017-01-26 14:00     ` martin rudalics
2017-01-26 15:43       ` Noam Postavsky
2017-01-26 16:10         ` Eli Zaretskii
2017-01-27  8:03       ` Dani Moncayo
2017-01-27  8:16         ` Eli Zaretskii
2017-01-27  8:22           ` Dani Moncayo
2017-01-27  9:19         ` martin rudalics
2017-01-27  9:25           ` Dani Moncayo
2017-01-27  9:31             ` Dani Moncayo
2017-01-27  9:50               ` martin rudalics
2017-01-27 10:22                 ` Dani Moncayo
2017-01-27 10:27                   ` Dani Moncayo
2017-01-27  9:34             ` martin rudalics
2017-01-27 10:01               ` Dani Moncayo
2017-01-27 13:47                 ` martin rudalics
2017-01-27 18:50                   ` Noam Postavsky
2017-01-28  8:02                     ` martin rudalics
2020-09-04 12:32                       ` Lars Ingebrigtsen
2020-09-04 17:50                         ` Dani Moncayo
2020-09-05  6:46                           ` Eli Zaretskii
2020-09-05 11:59                             ` Dani Moncayo
2020-09-05 12:17                               ` Eli Zaretskii
2020-09-05 12:19                                 ` Dani Moncayo
2020-09-05 12:30                                   ` Eli Zaretskii
2020-09-05 12:32                                     ` Dani Moncayo
2020-09-05 12:48                                       ` Eli Zaretskii
2020-09-05 15:10                                       ` Ken Brown
2020-09-05 16:07                                         ` Eli Zaretskii [this message]
2020-09-05 16:10                                           ` Ken Brown
2020-09-05 16:41                                             ` Eli Zaretskii
2020-09-09  8:44                               ` martin rudalics
2020-09-09 16:46                                 ` Dani Moncayo
2020-09-09 18:19                                 ` Ken Brown
2020-09-09 20:24                                   ` Ken Brown
2020-09-10  7:16                                     ` martin rudalics
2020-09-10 15:05                                       ` Ken Brown
2020-09-10 18:16                                         ` martin rudalics
2020-09-10 19:04                                           ` Ken Brown
2020-09-11  7:53                                             ` martin rudalics
2020-09-11 20:16                                               ` Ken Brown
2020-09-11 20:33                                                 ` Achim Gratz
2020-09-11 21:18                                                   ` Ken Brown
2020-09-12  6:54                                                     ` martin rudalics
2020-09-12 11:37                                                       ` Ken Brown
2020-09-12  6:54                                                   ` martin rudalics
2020-09-12  6:06                                                 ` Eli Zaretskii
2020-09-12  6:54                                                 ` martin rudalics
2017-01-26 16:08   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=835z8sp5pi.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=25542@debbugs.gnu.org \
    --cc=dmoncayo@gmail.com \
    --cc=kbrown@cornell.edu \
    --cc=larsi@gnus.org \
    --cc=npostavs@users.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.