From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: 41852@debbugs.gnu.org, thomas.hisch@ims.co.at
Subject: bug#41852: 27.0.50; text-scale commands don't scale header of tabulated-list-mode
Date: Fri, 30 Oct 2020 22:53:01 +0200 [thread overview]
Message-ID: <835z6ra11u.fsf@gnu.org> (raw)
In-Reply-To: <CADwFkm=47EogW7h7bO3FVGS+xdWofoU4q2kKCOQyd4mXzzg-iQ@mail.gmail.com> (message from Stefan Kangas on Fri, 30 Oct 2020 20:22:58 +0000)
> From: Stefan Kangas <stefan@marxist.se>
> Date: Fri, 30 Oct 2020 20:22:58 +0000
> Cc: rudalics@gmx.at, thomas.hisch@ims.co.at, 41852@debbugs.gnu.org
>
> > No, only faces that inherit from 'default' are scaled. And now so
> > will the faces that inherit from 'header-line'.
>
> When I use my patch in emacs -Q, say `M-x list-buffer' and then evaluate
> this in that buffer:
>
> (setq-local header-line-format (concat
> (propertize "foo" 'face 'mode-line) " "
> (propertize "bar" 'face 'bold)))
>
> Both "foo" and "bar" in the header line is scaled with the rest of the
> buffer. But I don't think either of those faces inherits from the
> header-line face.
Try using fixed-pitch and variable-pitch instead of mode-line and
bold. What happens then? And what does that mean for this
discussion?
> > No, not every face inherits from 'default', only those that inherit
> > explicitly.
>
> `(elisp) Basic Faces' says that they do:
>
> ‘default’
> The default face, whose attributes are all specified. All other
> faces implicitly inherit from it: any unspecified attribute
> defaults to the attribute on this face (*note Face Attributes::).
>
> So I'm not sure I understand what you are saying.
You said it yourself: "any _unspecified_ attribute".
> > A random face that is defined with defface isn't affected by
> > text-scale-*.
>
> What do you mean by "random face" here? When I do this, the text "bar"
> is scaled along with the rest:
>
> (progn
> (defface foo-face '((t :weight bold)) "")
> (pop-to-buffer (get-buffer-create "*test*"))
> (insert "foo\n")
> (insert (propertize "bar\n" 'face 'foo-face))
> (insert "baz\n")
> (text-scale-increase 1))
>
> Or could you give an example of where this does not happen?
I just did: fixed-pitch and variable-pitch. Another example would be
any defface that specifies :height as an absolute number of 1/10
point.
> >> (progn
> >> (fundamental-mode)
> >> (insert (propertize "foo" 'face '(:height 1.5)))
> >> (text-scale-increase))
> >>
> >> What am I missing?
> >
> > See above.
>
> Could you elaborate? What I see is that this anonymous face is scaled.
Because you specified :height as 1.5 times the default, i.e. relative
to the default face.
next prev parent reply other threads:[~2020-10-30 20:53 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-14 13:36 bug#41852: 27.0.50; text-scale commands don't scale header of tabulated-list-mode Thomas Hisch
2020-06-14 14:42 ` Eli Zaretskii
2020-06-14 16:25 ` Thomas Hisch
2020-10-18 23:34 ` Stefan Kangas
2020-10-19 14:19 ` Eli Zaretskii
2020-10-19 18:21 ` Stefan Kangas
2020-10-19 19:02 ` Eli Zaretskii
2020-10-19 22:41 ` Stefan Kangas
2020-10-20 14:15 ` Eli Zaretskii
2020-10-20 14:40 ` Stefan Kangas
2020-10-20 14:45 ` Eli Zaretskii
2020-10-20 19:10 ` Thomas Hisch
2020-10-29 17:43 ` Stefan Kangas
2020-10-29 19:37 ` Thomas Hisch
2020-10-29 21:45 ` Stefan Kangas
2020-10-30 8:01 ` Eli Zaretskii
2020-10-29 17:33 ` Stefan Kangas
2020-10-29 18:02 ` Drew Adams
2020-10-29 18:15 ` Stefan Kangas
2020-10-29 18:32 ` Drew Adams
2020-10-29 18:47 ` Stefan Kangas
2020-10-30 8:54 ` martin rudalics
2020-10-30 16:04 ` Stefan Kangas
2020-10-30 17:37 ` martin rudalics
2020-10-30 19:01 ` Eli Zaretskii
2020-10-31 0:31 ` Stefan Kangas
2020-10-31 8:00 ` martin rudalics
2020-10-30 18:54 ` Eli Zaretskii
2020-10-30 20:22 ` Stefan Kangas
2020-10-30 20:53 ` Eli Zaretskii [this message]
2020-10-31 16:15 ` Stefan Kangas
2020-10-31 16:48 ` Eli Zaretskii
2020-10-31 16:57 ` Eli Zaretskii
2020-10-31 17:55 ` Eli Zaretskii
2020-11-12 22:25 ` Stefan Kangas
2020-11-13 7:51 ` Eli Zaretskii
2020-11-25 2:08 ` Stefan Kangas
2020-11-13 8:49 ` martin rudalics
2020-11-25 2:08 ` Stefan Kangas
2020-11-13 13:00 ` Jean Louis
2020-11-13 14:32 ` Stefan Kangas
2020-11-13 15:33 ` Jean Louis
2020-11-13 16:07 ` github.com
2020-11-13 16:49 ` Stefan Kangas
2020-10-31 16:50 ` Stefan Kangas
2020-10-31 8:29 ` Eli Zaretskii
2020-10-31 16:25 ` Stefan Kangas
[not found] <<955fe4fe-a64d-b7c6-fe31-7efd810f97a5@ims.co.at>
[not found] ` <<83mu553e0x.fsf@gnu.org>
2020-06-14 16:28 ` Drew Adams
2020-06-14 17:23 ` Thomas Hisch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=835z6ra11u.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=41852@debbugs.gnu.org \
--cc=stefan@marxist.se \
--cc=thomas.hisch@ims.co.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.