From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#44341: 27.1; define-minor-mode generates inaccurate docstring Date: Mon, 02 Nov 2020 17:52:38 +0200 Message-ID: <835z6neoxl.fsf@gnu.org> References: <87361u64oo.fsf@thb.lt> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12378"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 44341@debbugs.gnu.org, thibault@thb.lt, monnier@iro.umontreal.ca To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 02 16:53:08 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kZc8q-00036n-HX for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 02 Nov 2020 16:53:08 +0100 Original-Received: from localhost ([::1]:39480 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZc8p-0008Gv-Kw for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 02 Nov 2020 10:53:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:32998) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZc8k-0008Go-OL for bug-gnu-emacs@gnu.org; Mon, 02 Nov 2020 10:53:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58931) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kZc8k-0003kx-EC for bug-gnu-emacs@gnu.org; Mon, 02 Nov 2020 10:53:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kZc8k-0005jM-BT for bug-gnu-emacs@gnu.org; Mon, 02 Nov 2020 10:53:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 Nov 2020 15:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44341 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 44341-submit@debbugs.gnu.org id=B44341.160433237722017 (code B ref 44341); Mon, 02 Nov 2020 15:53:02 +0000 Original-Received: (at 44341) by debbugs.gnu.org; 2 Nov 2020 15:52:57 +0000 Original-Received: from localhost ([127.0.0.1]:42244 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZc8f-0005j3-1p for submit@debbugs.gnu.org; Mon, 02 Nov 2020 10:52:57 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:32808) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZc8d-0005iq-J6 for 44341@debbugs.gnu.org; Mon, 02 Nov 2020 10:52:56 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:48714) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZc8W-0003ip-Tn; Mon, 02 Nov 2020 10:52:48 -0500 Original-Received: from [176.228.60.248] (port=2183 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kZc8W-0002qO-9N; Mon, 02 Nov 2020 10:52:48 -0500 In-Reply-To: (message from Philipp Stephani on Mon, 2 Nov 2020 13:28:06 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192538 Archived-At: > From: Philipp Stephani > Date: Mon, 2 Nov 2020 13:28:06 +0100 > Cc: 44341@debbugs.gnu.org, Thibault Polge > > Am So., 1. Nov. 2020 um 16:30 Uhr schrieb Stefan Monnier > : > > > > disable ; Should disable (as a random symbol) > > > disable ; Again > > > "What?" ; Same. > > > > These should be considered as errors. Whether we catch them and signal > > an error or silently do something else is not particular important > > to me. > > We should definitely signal an error here. A form such as (my-mode > 'enable) actually disabling the mode is very confusing. Signaling an error would be an incompatible change. Someone who has (my-mode 'disable) in their Lisp code will complain that it makes perfect sense. I object to making incompatible changes in this area; let's fix the problems wrt documentation, but it's too late to introduce incompatible changes into this stuff, which is used all over, in Emacs and elsewhere. Wed already had the first bug report about such incompatible changes, less than a day after it was pushed. I'm quite certain that incompatible change was unintended, but here you propose to make it quite intentionally, and that would be a serious mistake, IMO.