From: Eli Zaretskii <eliz@gnu.org>
To: Alan Third <alan@idiocy.org>
Cc: 44349@debbugs.gnu.org, p.stephani2@gmail.com
Subject: bug#44349: 28.0.50; Assertion failure on macOS when resizing frame
Date: Sun, 29 Nov 2020 17:10:03 +0200 [thread overview]
Message-ID: <835z5omc6s.fsf@gnu.org> (raw)
In-Reply-To: <20201128220645.GF26836@breton.holly.idiocy.org> (message from Alan Third on Sat, 28 Nov 2020 22:06:45 +0000)
> Date: Sat, 28 Nov 2020 22:06:45 +0000
> From: Alan Third <alan@idiocy.org>
> Cc: p.stephani2@gmail.com, 44349@debbugs.gnu.org
>
> > Thanks! Can we add tests for this?
>
> I was wondering that. How do we add tests for internal C functions?
By calling Lisp functions which call them. But maybe it isn't
possible in this case.
Wait, isn't the use case which caused this bug report a suitable test
for the change?
> > Silently ignoring parts of input sounds ... unusual, so I wonder what
> > would it take to avoid that. How did the old code avoid this problem?
>
> This situation can only be caused by calling doprnt with format_end
> set to some point inside a multibyte character (it's a pointer).
Ah, okay. In that case, I think ignoring the invalid sequence is OK,
but let's document that in the function's commentary.
Thanks.
next prev parent reply other threads:[~2020-11-29 15:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-31 15:51 bug#44349: 28.0.50; Assertion failure on macOS when resizing frame Philipp
2020-10-31 15:57 ` Philipp Stephani
2020-10-31 16:03 ` Philipp Stephani
2020-10-31 16:35 ` Eli Zaretskii
2020-10-31 16:43 ` Philipp Stephani
2020-10-31 16:52 ` Eli Zaretskii
2020-11-27 22:24 ` Alan Third
2020-11-28 7:51 ` Eli Zaretskii
2020-11-28 22:06 ` Alan Third
2020-11-29 10:27 ` Lars Ingebrigtsen
2020-11-29 15:10 ` Eli Zaretskii [this message]
2020-11-29 17:16 ` Alan Third
2020-11-29 17:23 ` Eli Zaretskii
2020-11-29 17:43 ` Alan Third
2020-11-01 0:55 ` Alan Third
2020-11-01 0:58 ` Alan Third
2020-11-01 1:00 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=835z5omc6s.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=44349@debbugs.gnu.org \
--cc=alan@idiocy.org \
--cc=p.stephani2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.