From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#45550: [PATCH] Factor out new function for readability in chartab.c Date: Thu, 31 Dec 2020 05:29:08 +0200 Message-ID: <835z4iirgb.fsf@gnu.org> References: <83k0szhwz1.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6167"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 45550@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 31 04:30:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kuofD-0001Sq-1c for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 31 Dec 2020 04:30:11 +0100 Original-Received: from localhost ([::1]:48568 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kuofC-00068r-4h for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Dec 2020 22:30:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42064) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kuof5-00067h-AT for bug-gnu-emacs@gnu.org; Wed, 30 Dec 2020 22:30:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40079) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kuof5-00069n-2T for bug-gnu-emacs@gnu.org; Wed, 30 Dec 2020 22:30:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kuof4-0001fM-RY for bug-gnu-emacs@gnu.org; Wed, 30 Dec 2020 22:30:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 31 Dec 2020 03:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45550 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 45550-submit@debbugs.gnu.org id=B45550.16093853726342 (code B ref 45550); Thu, 31 Dec 2020 03:30:02 +0000 Original-Received: (at 45550) by debbugs.gnu.org; 31 Dec 2020 03:29:32 +0000 Original-Received: from localhost ([127.0.0.1]:51625 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuoeZ-0001eE-LY for submit@debbugs.gnu.org; Wed, 30 Dec 2020 22:29:31 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:48802) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuoeW-0001dy-HB for 45550@debbugs.gnu.org; Wed, 30 Dec 2020 22:29:29 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:40037) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kuoeQ-0005xr-Vs; Wed, 30 Dec 2020 22:29:23 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1783 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kuoeP-0000S8-1L; Wed, 30 Dec 2020 22:29:22 -0500 In-Reply-To: (message from Stefan Kangas on Wed, 30 Dec 2020 15:16:05 -0600) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:197056 Archived-At: > From: Stefan Kangas > Date: Wed, 30 Dec 2020 15:16:05 -0600 > Cc: 45550@debbugs.gnu.org > > Eli Zaretskii writes: > > > Please make this a macro, not a function. The code you are factoring > > out is called in the innermost loops of the display engine, in bidi.c, > > so it must be as fast as possible, even in an unoptimized build, where > > static functions aren't inlined. > > Would it be acceptable to use our INLINE macro here instead? I'd prefer a simple macro. I can never remember the exact semantics of INLINE this week. Thanks.