all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: roucaries.bastien@gmail.com
Cc: 46051@debbugs.gnu.org
Subject: bug#46051: 27.1; Nroff preview does not work with file that include space in path (quoting problem ?)
Date: Sat, 30 Jan 2021 11:00:04 +0200	[thread overview]
Message-ID: <835z3eajfv.fsf@gnu.org> (raw)
In-Reply-To: <83tur751s1.fsf@gnu.org> (message from Eli Zaretskii on Sat, 23 Jan 2021 13:30:06 +0200)

Ping!  Please see if the patch below fixes the problem, so that we
could install it.  TIA.

> Date: Sat, 23 Jan 2021 13:30:06 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: 46051@debbugs.gnu.org
> 
> > From: Bastien ROUCARIES <roucaries.bastien@gmail.com>
> > Date: Sat, 23 Jan 2021 11:11:09 +0000
> > Cc: 46051@debbugs.gnu.org
> > 
> > > > I believe this is a quoting problem but I am not a lisp expert.
> > >
> > > Do you mean the nroff-view command?  Or do you mean something else?
> > 
> > Yes I means this command.
> > 
> > It faill when running for instance from "/tmp/dir whith space/someman.1"
> 
> Does the patch below fix the problem?
> 
> diff --git a/lisp/textmodes/nroff-mode.el b/lisp/textmodes/nroff-mode.el
> index 8965785..7e54755 100644
> --- a/lisp/textmodes/nroff-mode.el
> +++ b/lisp/textmodes/nroff-mode.el
> @@ -319,7 +319,7 @@ nroff-view
>  	 (save-buffer))
>      (if viewbuf
>  	(kill-buffer viewbuf))
> -    (Man-getpage-in-background file)))
> +    (Man-getpage-in-background (shell-quote-argument file))))
>  
>  (provide 'nroff-mode)
>  
> 
> 
> 
> 





  reply	other threads:[~2021-01-30  9:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-23 10:57 bug#46051: 27.1; Nroff preview does not work with file that include space in path (quoting problem ?) Bastien Roucariès
2021-01-23 11:08 ` Eli Zaretskii
2021-01-23 11:11   ` Bastien ROUCARIES
2021-01-23 11:30     ` Eli Zaretskii
2021-01-30  9:00       ` Eli Zaretskii [this message]
2021-02-06 13:11         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=835z3eajfv.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=46051@debbugs.gnu.org \
    --cc=roucaries.bastien@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.