bug#52367: 27.2; lgrep and grep-files-aliases

bug#52367: 27.2; lgrep and grep-files-aliases

[Maxence Dutielt]

emacs -Q
M-x lgrep
Search for: foo
Search for "foo" in files matching wildcard (default all): all
In directory: ~/foobar

will always output this error if you don't have any filename starting
with two dots:

grep: ..?*: No such file or directory
Grep exited abnormally with code 2

I noticed "..?*" was introduced here:
commit ref: 856cd948d1a5a016ad36721246a049d33451902f
after reviewing bug #22577 (archived):
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=22577

Now that Emacs is smarter at quoting shell commands (at least on 27.2),
"* .[!.]* ..?*" seems overcomplicated and no longer necessary.

I couldn't reproduce bug #22577 with vc-git-grep as mentioned, using
both BSD and GNU grep on Linux, Windows and macOS.

Since "* .*" works as expected again, and doesn't produce the error of
"..?*", I think it should be reverted back into grep-files-aliases.

Lastly, to avoid such messages when using lgrep:

grep: foobar: Is a directory

We could add the parameter --directories=skip by default, since lgrep is
not for recursive search.

bug#52367: 27.2; lgrep and grep-files-aliases

[Óscar Fuentes]

I would like to revert my 856cd948d1a5a016ad36721246a049d33451902f since
the problem it addresses is no longer such problem (thanks to
improvements on shell parameter quoting) and right now it is causing a
regression on lgrep.

Okay to revert it on emacs-28?

bug#52367: 27.2; lgrep and grep-files-aliases

[Eli Zaretskii]

> From: Óscar Fuentes <ofv@wanadoo.es>
> Date: Wed, 08 Dec 2021 03:33:15 +0100
> Cc: Maxence Dutielt <m@dutielt.com>
> 
> I would like to revert my 856cd948d1a5a016ad36721246a049d33451902f since
> the problem it addresses is no longer such problem (thanks to
> improvements on shell parameter quoting) and right now it is causing a
> regression on lgrep.
> 
> Okay to revert it on emacs-28?

Yes, thanks.

bug#52367: 27.2; lgrep and grep-files-aliases

[Eli Zaretskii]

> Date: Wed, 8 Dec 2021 01:54:26 +0100
> From: Maxence Dutielt <m@dutielt.com>
> Cc: ofv@wanadoo.es
> 
> We could add the parameter --directories=skip by default, since lgrep is
> not for recursive search.

That's only supported by GNU Grep, right?

bug#52367: 27.2; lgrep and grep-files-aliases

[Maxence Dutielt]

> That's only supported by GNU Grep, right?

It is supported by the BSD grep shipped with macOS:

grep --version
grep (BSD grep) 2.5.1-FreeBSD

But it is not by the BSD grep shipped with OpenBSD.

The grep variant in OpenBSD already skips directories by default if you 
don't provide the recursive option.

bug#52367: 27.2; lgrep and grep-files-aliases

[Óscar Fuentes]

Eli Zaretskii <eliz@gnu.org> writes:

>> Okay to revert it on emacs-28?
>
> Yes, thanks.

Done.

@ Maxence Dutielt : please open a new issue for discussing the
--directories=skip change you propose. Thank you.